1721352 - Convert composition field role=button xul:label elements to html:button

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task)

Description

[Henry Wilkes (they/them) [:henry-x]]

Its advisable to use semantic elements for a given role where possible, and style them to match a desired look. This way, additional (accessibility) behaviour associated with the element will be carried over.

For instance, the current <xul:label role="button"> elements used to reveal additional composition fields (CC, BCC, Reply-To etc) are not activated with a Space keyboard press, unlike <html:button>.

Comment 1

[Alessandro Castellani [:aleca]]

Tracking for 91 if we manage to do this change without touching the strings.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Alessandro Castellani [:aleca] from comment #1)

Tracking for 91 if we manage to do this change without touching the strings.

Unfortunately there isn't a way to do this. The "To", "CC" and "BCC" <xul:label role="button"> fluent entries use .value and .tooltiptext, and this would need to change to the textContent and .title respectively, which requires a new fluent id.

Comment 3

[Richard Marti (:Paenglab)]

You could also create a migration file that migrates the strings to the correct entities: https://searchfox.org/comm-central/source/python/l10n/tb_fluent_migrations. FX has a lot of examples too.

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Richard Marti (:Paenglab) from comment #3)

You could also create a migration file that migrates the strings to the correct entities: https://searchfox.org/comm-central/source/python/l10n/tb_fluent_migrations. FX has a lot of examples too.

Thanks, I did not know about migration files. I'll look into it.

Comment 5

[Richard Marti (:Paenglab)]

They are mostly to migrate dtd and properties to ftl but also changes of entities in ftl should work.

Comment 6

[Alessandro Castellani [:aleca]]

For what I know, string migrations are not run often but only rarely, on specific times, and all together by the m-c folks.
Unless we moved to something more independent in the past year, it's better to not think about migrations and focus on the bug first.
We can always uplift to a point release of 91 if it's necessary and we can easily migrate strings.

Comment 7

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1721352 - Replace "show address row" xul labels with buttons and menuitems. r=aleca

Also changed the representation of the extra buttons from a xul:panel to a menupopup.

Also removed the (already broken) arrow key navigation between the main buttons and the extra buttons, since the latter set are no longer semantically buttons and keyboard navigation between buttons and the internals of a popup menu would be confusing.

Also tidied up some existing approaches used for the address rows.

Comment 8

[Henry Wilkes (they/them) [:henry-x]]

Running the tests here https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=eea4facb8af716d5f7289f58dae67242d3224a55

After fixing browser_replyAddresses.js and browser_redirect.js https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=e57a13d6fc0e5e54e85183a1d4e1717a434ed2f2

Comment 9

[Alessandro Castellani [:aleca]]

The browser_sendButton.js is failing on macOS. That failure doesn't seem related to the currently reported perma-fails.

Comment 10

[Alessandro Castellani [:aleca]]

Attachment: menupopup.png

This is getting better, but we need some polish.
Attached you can find the screenshot with a comparison.

• Since this menu items won't show an image nor a checkmark, we don't need that space to the left. We should create a class to override this.
• The margin inline of the menuitems is a bit too large and it creates a visual variation with the margin above and below the items. (This affects also the folder pane popup, so not directly related tot his bug)
• The order of the menuitems is not correct.
  Reply-to, Newsgroup, Followup-To, *others, is the correct default order that should be kept.
  Once the identity is changed and those items are shuffled to reflect the different available headers, the order doesn't matter that much, but the Reply-to should always be the first since it's always the consistently available addressing field.

Comment 11

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1721352 - Clean up usage of address row and input classes. r=aleca

• Added the address-row-input class to more clearly find the non-pill inputs of a row.
• Stopped duplicating the address row's recipienttype information in its inputs.
• Added the address-row-raw class to mark additional raw headers, that do not use pills.
• Dropped the unnecessary addressingWidgetItem class, since address-row is sufficient.

Comment 12

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1721352 - Prevent dropping pills in raw address inputs. r=aleca

Drop operation is now successfully cancelled when dropping on a custom raw address header.

Depends on D122615

Comment 13

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1721352 - Sanitise header names in mail.compose.other.header preference. r=aleca

Depends on D122616

Comment 14

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1721352 - Replace showAddressRow with showAndFocusAddressRow. r=aleca

Rename emphasises that this method will shift focus, and we can drop the label argument since the recipienttype data on the row is sufficient to find it.

Depends on D122617

Comment 15

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1721352 - Reduce code reuse in CompFields2Recipients. r=aleca

Depends on D122618

Comment 16

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1721352 - Change some methods to act on address rows. r=aleca

Depends on D122619

Comment 17

[Henry Wilkes (they/them) [:henry-x]]

Latest tests https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=61e2d08b9962470d8c40d068a5b790407349c1c1&selectedTaskRun=EzKpmS2JTy-EzZRhjcbEog.0

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/655c13cf015c
Clean up usage of address row and input classes. r=aleca
https://hg.mozilla.org/comm-central/rev/231af778c21d
Prevent dropping pills in raw address inputs. r=aleca
https://hg.mozilla.org/comm-central/rev/66bc5953481d
Sanitise header names in mail.compose.other.header preference. r=aleca
https://hg.mozilla.org/comm-central/rev/e0a5948d0790
Replace showAddressRow with showAndFocusAddressRow. r=aleca
https://hg.mozilla.org/comm-central/rev/56fd87c2a30a
Reduce code reuse in CompFields2Recipients. r=aleca
https://hg.mozilla.org/comm-central/rev/da77ce116ee9
Change some methods to act on address rows. r=aleca
https://hg.mozilla.org/comm-central/rev/45d336c01d5f
Replace "show address row" xul labels with buttons and menuitems. r=aleca