1772000 - CC field disclosure button shows keyboard short for To (Ctrl+Shift+T)

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: CC disclosure button shows keyboard short for To (Ctrl+Shift+T)

103.0a1 (2022-05-31) (64-bit), Win 10

Actual: CC disclosure button shows keyboard shortcut for To (Ctrl+Shift+T)
Expected: CC disclosure button should show keyboard shortcut for CC (Ctrl+Shift+C)

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Good spot. It was a typo from https://hg.mozilla.org/comm-central/rev/45d336c01d5f#l2.93

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1772000 - Fix typo in compose "Cc" button's title. r=aleca

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/56d7d57e0739
Fix typo in compose "Cc" button's title. r=mkmelin

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9279062 [details]
Bug 1772000 - Fix typo in compose "Cc" button's title. r=aleca

[Approval Request Comment]
Regression caused by (bug #): Bug 1721352
User impact if declined: Wrong shortcut in the Cc button title.
Testing completed (on c-c, etc.): No tests
Risk to taking this patch (and alternatives if risky): Low. This just fixes a typo on one line.

Comment 5

[Thomas D. (:thomas8)]

Awesome. Thanks Henry & Magnus for fast fix!

Comment 6

[Thomas D. (:thomas8)]

(In reply to Thomas D. (:thomas8) from comment #5)

Awesome. Thanks Henry & Magnus for fast fix!

Verified fixed on 103.0a1 (2022-06-01) (64-bit) - no more shortcut confusion :-)

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9279062 [details]
Bug 1772000 - Fix typo in compose "Cc" button's title. r=aleca

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.0beta2:
https://hg.mozilla.org/releases/comm-beta/rev/4c139c25b541