1721584 - Pocket, highlights and snippets icons missing in settings "Home" pane

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[:Gijs (he/him)]

Attachment: Screenshot

[Tracking Requested - why for this release]:
There are missing images in the settings UI here and we have not yet shipped this regression.

We should reinstate these images.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1721584 - reinstate about:preferences icons for various new tab categories, r?andreio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea1ac3b6ba50
reinstate about:preferences icons for various new tab categories, r=andreio,perftest-reviewers,kimberlythegeek

Comment 3

[:Gijs (he/him)]

Comment on attachment 9232350 [details]
Bug 1721584 - reinstate about:preferences icons for various new tab categories, r?andreio

Beta/Release Uplift Approval Request

• User impact if declined: Missing icons
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open about:preferences, then open the "Home" pane. All the main items (checkboxes with bold labels) should have icons
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a pretty straightforward search/replace patch for references to the old icons, and it's easy to verify that the icons appear in the correct places.
• String changes made/needed: Nope

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ea1ac3b6ba50

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9232350 [details]
Bug 1721584 - reinstate about:preferences icons for various new tab categories, r?andreio

Low risk regression fix, approved for 91 beta 6, thanks.

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/829a16a588d1

Comment 7

[Catalin Sasca, Desktop QA [:csasca]]

Reproduced the issue on Firefox 91.0b5 under macOS 10.15.7.

The missing icons are back on Firefox 91.0b6 and Firefox 92.0a1 (2021-07-22). Tests were performed on macOS 10.15, Ubuntu 20.04 and Windows 10.