Closed Bug 1721584 Opened 3 years ago Closed 3 years ago

Pocket, highlights and snippets icons missing in settings "Home" pane

Categories

(Firefox :: New Tab Page, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
92 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox90 --- unaffected
firefox91 + verified
firefox92 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Screenshot

[Tracking Requested - why for this release]:
There are missing images in the settings UI here and we have not yet shipped this regression.

We should reinstate these images.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
See Also: → 1721627
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ea1ac3b6ba50 reinstate about:preferences icons for various new tab categories, r=andreio,perftest-reviewers,kimberlythegeek

Comment on attachment 9232350 [details]
Bug 1721584 - reinstate about:preferences icons for various new tab categories, r?andreio

Beta/Release Uplift Approval Request

  • User impact if declined: Missing icons
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Open about:preferences, then open the "Home" pane. All the main items (checkboxes with bold labels) should have icons
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's a pretty straightforward search/replace patch for references to the old icons, and it's easy to verify that the icons appear in the correct places.
  • String changes made/needed: Nope
Attachment #9232350 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Comment on attachment 9232350 [details]
Bug 1721584 - reinstate about:preferences icons for various new tab categories, r?andreio

Low risk regression fix, approved for 91 beta 6, thanks.

Attachment #9232350 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Reproduced the issue on Firefox 91.0b5 under macOS 10.15.7.

The missing icons are back on Firefox 91.0b6 and Firefox 92.0a1 (2021-07-22). Tests were performed on macOS 10.15, Ubuntu 20.04 and Windows 10.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: