1721627 - Add code to chrome/jar channels that crashes in debug builds if trying to read non-existent files from omni.ja and similar packages

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

bug 1721584 involves some icons that went AWOL after some refactoring . It would have been nice if the regressing bug 1708502, which stopped shipping those icons, would have turned the tree orange.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1721627 - crash on requests to non-existing chrome: and resource: files on infra, r?#necko-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a670f5679e0b
crash on requests to non-existing chrome: and resource: files on infra, r=necko-reviewers,valentin

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1721627 - follow-up: don't crash on android due to AttributionCode.jsm or reftest hits, see bug 1722082, rs=bustage

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc5e08d27347
follow-up: don't crash on android due to AttributionCode.jsm or reftest hits, see bug 1722082, rs=bustage CLOSED TREE

Comment 5

[Rob Wu [:robwu]]

Note that the use of xpc::IsInAutomation means that the check doesn't cover xpcshell tests (bug 1598804).

Comment 6

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1721627) for Talos failures. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=347202557&repo=autoland&lineNumber=2045

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=a670f5679e0be52691261833eab3fb6beac8f044

Backout:
https://hg.mozilla.org/integration/autoland/rev/f077a7402e9c90d3f264c940962f908100f7e967

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a670f5679e0b
https://hg.mozilla.org/mozilla-central/rev/bc5e08d27347

Comment 8

[:Gijs (he/him)]

(In reply to Dorel Luca [:dluca] from comment #6)

Backed out 2 changesets (bug 1721627) for Talos failures.

lolsigh, tart uses dead favicons...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cded8230dac
crash on requests to non-existing chrome: and resource: files on infra, r=necko-reviewers,valentin

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5cded8230dac