1578975 - Remove message manager codepath in Storage actor

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, task, P3)

Description

[Julian Descottes [:jdescottes]]

When fission.autostart is enabled the message manager will not be available when debugging frames. The storage actor is directly using the message manager to exchange messages between its content and its parent actors.

Instead of directly using the message manager, we should use APIs provided by DevTools (maybe on debugger-server-connection?) that would transparently use the message manager or js-window-actors.

https://searchfox.org/mozilla-central/search?q=mm.&case=false&regexp=false&path=actors%2Fstorage

Comment 1

[Yulia Startsev [:yulia]]

Is this message manager the process message manager? if that is the case, we can close this.

Comment 2

[Julian Descottes [:jdescottes]]

(In reply to Yulia Startsev [:yulia] from comment #1)

Is this message manager the process message manager? if that is the case, we can close this.

No, it's the message manager provided by setupInParent, so it's the frameloader's message manager.
https://searchfox.org/mozilla-central/rev/e5327b05c822cdac24e233afa37d72c0552dbbaf/devtools/server/connectors/frame-connector.js#99

Comment 3

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6)

Comment 4

[Chris Peterson [:cpeterson]]

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Comment 5

[Chris Peterson [:cpeterson]]

Tracking dt-fission-reserve bugs for Fission MVP until we know whether they really need to block Fission or not.

Comment 6

[Chris Peterson [:cpeterson]]

Moving old "dt-fission-reserve" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 7

[Alexandre Poirot [:ochameau]]

Slightly refocusing the purpose of this bug to remove message manager related code in the storage actor.
Now that all storage types are being listened via the Resource Watchers (bug 1772822), including extension storage (bug 1666534),
the storages actors are no longer instantiated "the old way", from the target-scoped storage actor.
Instead they are all instantiated from the right process, from resource watchers.

It means that we can drop all cross process messaging from actors/storage.js and probably simplify the codebase by merging each actor into each related resource watcher.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1578975 - [devtools] Remove now-useless pre-resource-watchers cross process messaging code from storage actor.

This glue, necessary to communicated between content and parent processes
was only necessary when manually spawning the storage actors.
Now that this code is only used via ResourceWatcher, running in the right process
right away, we no longer need any cross process communication.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1578975 - [devtools] Remove now-unused setupInParent code.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9bca9f89901
[devtools] Remove now-useless pre-resource-watchers cross process messaging code from storage actor. r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/5d70f7333ecc
[devtools] Remove now-unused setupInParent code. r=devtools-reviewers,jdescottes

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b9bca9f89901
https://hg.mozilla.org/mozilla-central/rev/5d70f7333ecc