1722078 - Fenix tries to load non-existent app-extension-fields.properties l10n file

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1722076 +++

In bug 1721627 I'm experimenting with making tests fail if we request internal resources that aren't present. The idea is to prevent patches from landing if they mis-spell (or forget to hg add, or forget to include in jar.mn or similar) subresources like CSS files and images, by failing if we hit chrome: or resource: URLs in tests that are not available (ie where the internal jar/file code cannot find the relevant file).

In addition to bug 1721910, and bug 1722076 , android jobs appear to fail because XPIDatabase.jsm tries to load app-extension-fields.properties which does not exist on android.

Certainly maintaining the status quo without the added work of trying to load a non-existent file is the trivial fix here, so that's what I'm tempted to go for unless someone else thinks that's not right?

Comment 1

[Shane Caraveo (:mixedpuppy)]

Either the tests should ignore those particular properties files, or XPIDatabase should check if they exist before trying to access them.

https://searchfox.org/mozilla-central/rev/290f33a3245f61f34ec5f80f548e6584823ba9ad/toolkit/mozapps/extensions/internal/XPIDatabase.jsm#1328-1335

Comment 2

[Rob Wu [:robwu]]

This file isn't relevant on Android.

Not just this file, but global-extension-fields.properties is also referenced and not applicable to Android: https://searchfox.org/mozilla-central/rev/59e797b66f5ce8a27ede0e7677688931be7aed20/toolkit/mozapps/extensions/internal/XPIDatabase.jsm#164-167

It is present on Thunderbird though: https://searchfox.org/comm-central/rev/fb497c98fdee2320b4b261ec9591023bce8d554c/mail/locales/en-US/chrome/messenger/app-extension-fields.properties

Comment 3

[Rob Wu [:robwu]]

The translations are moving to Fluent as part of bug 1729738.
In the code review process I'm accounting for this bug, so once bug 1729738 is resolved this bug will probably be fixed too.

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1722078 - Remove obsolete reference to app-extension-fields.properties

The file is no longer being loaded since the patch for bug 1729738.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcfd527a95b4
Remove obsolete reference to app-extension-fields.properties r=Gijs,necko-reviewers,valentin

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bcfd527a95b4