1722643 - High-contrast theme hides toggle to enable a disabled add-on

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[MarjaE]

Attachment: Screen Shot 2021-07-27 at 11.19.52 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Set "Increase contrast" or other system settings for increased contrast.

2. Open about:preferences, search for color, set Override to "Always." Note that this will not use your color choices, this will use the standard high-contrast colors instead.

3. Open about:addns, disable an add-on.

Actual results:

4. about:addons doesn't show the toggle to re-enable any disabled add-on.

Expected results:

5. Should show the toggle.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Mark Striemer [:mstriemer]]

Thanks for the report! Any idea if this behaviour changed recently?

Comment 3

[MarjaE]

It had very low contrast in high-contrast to begin with

It goes invisible in high-contrast at

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b0b7678a67810f52147536f5ca65070ec476b36d&tochange=e3c6659f93f153cd28226958f45b6f664834f94f

with bug 1710852 and bug 1712617 changing high-contrast display styles.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 5

[Alex Cornestean]

Hello,

I’ve reproduced the issue on the latest Nightly (92.0a1/20210729214355), Beta (91.0b9/20210729185755) and Release (90.0.2/20210721174149) under macOS 11.3.1. However, not on Windows 10 x64 or Ubuntu 16.04 LTS.

I have enabled the “High Contrast” options on all of the tested OSes and followed through with the rest of the STR.

The toggle buttons are still visible on my end on Windows and Ubuntu. For more details, please see the attached image for a comparison between Ubuntu and Windows on all 3 tested versions.

For reference I’m using a P2419H Dell monitor on Windows and a Samsung s22b300h on Ubuntu. On both platforms the buttons are still visible. This is in case the visibility issue is somehow related to the actual display panel.

On macOS, however, even if the attached screenshot (macOS HC) shows at least a bit of visible contour, in reality the toggles are invisible.

Comment 6

[Alex Cornestean]

Attachment: windows-ubuntu high contrast.png

Comment 7

[Alex Cornestean]

Attachment: macOS HC.png

Comment 8

[Rob Wu [:robwu]]

Mark, could you look at this since you've authored the patches linked in comment 3?

And given the similar area, could you also take a look at bug 1723127?

Comment 9

[Tomislav Jovanovic :zombie]

Mark said this might be fixed by some other changes, and I just tested and couldn't reproduce with the 4 different High Contrast themes in Windows 10, can you please verify that Alex?

Comment 10

[Alex Cornestean]

Hello,

I’ve checked once more on Windows on the latest Nightly (94.0a1/20210913213224 ), Beta (93.0b4/20210912185727) and Release (92.0/20210903235534), but on this platform the switches were visible to begin with while a high contrast aid was active.

On macOS on the other hand, it’s still reproducible on the latest Nightly. I’ll attach some photos for more details.

Comment 11

[Alex Cornestean]

Attachment: 473EB7D6-FF13-4CCC-9A4C-ECC3946396FF.jpg

Comment 12

[Alex Cornestean]

Attachment: A266C04D-7A98-434B-9B1E-BC3EB8EEDD4B.jpg

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

needinfo-ing myself as reminder to look into who would be a good pick to needinfo about this high contrast-related bugs.

Comment 14

[Mark Striemer [:mstriemer]]

Adding to the MSU high-contrast bug tracker

Comment 15

[Luca Greco [:rpl] [:luca] [:lgreco]]

Thank you Mark and Micah, that's exactly what I was looking for.

Comment 16

[Micah [:mtigley] (she/her)]

It looks like there's a patch up in Bug 1734235 that already resolves this issue. Once that's fixed, this issue should also be resolved.

Comment 18

[Dão Gottwald [:dao]]

Hanna, can we close this?

Comment 19

[Hanna Jones [:hjones]]

It looks like this improved on Mac OS with the new toggle but is still a bit buggy. We have some newer designs for how the toggle should look in HCM - I'll file a follow up ticket to implement those (making sure we also verify the Mac OS high contrast case). Let's wait to close this until that work is done.

Comment 20

[Hanna Jones [:hjones]]

Attachment: MacOS increased contrast + override colors enabled

I believe this should have been fixed via the changes made for Bug 1798404. Testing locally it looks like enabled and disabled toggles are visible both on MacOS with increased contrast and color overrides enabled and on Windows with different high contrast themes applied.

Comment 21

[Hanna Jones [:hjones]]

Attachment: Windows HCM