1722730 - CardDAV Address book not recognized as read-only

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Дилян Палаузов]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

In TB91b4 I open the Address Book, select File → New → CardDAV address book. As username I enter [e-mail], TB fills as location aegee.org . → Continue. TB shows the available address books. → Continue. TB does not ask for password and finishes the address book.

Actual results:

Once the addressbook is setup, I click on the left on “Bodies” → Properties. The address book is not marked as Read-only.

Expected results:

Since the WebDAV ACL calls confirm, that the address book is read-only, Thunderbird shall have marked automatically the address book as read-only.

Comment 1

[Magnus Melin [:mkmelin]]

Lasana, you fixed the CalDAV case, can you fix CardDAV as well?

Comment 2

[Lasana Murray]

If I recall correctly, I believe I modified the CardDav code as well. Are you able to tell us what CardDav server you are using Дилян Палаузов ?

Comment 3

[Дилян Палаузов]

I reopened bug 1670416, which is about the same, but for CalDAV. The reason is, that in the released TB91 read-only CalDAV calendars are again not marked automatically marked as Read-only by TB91-released during the setup.

In TB91-released I go to Tools → Address Book → File → New → CardDAV Address Book… . As location I enter aegee.org without username, → Continue. TB finds one calendar (Bodies) but does not issue DAV:acl-principal-prop-set REPORT. Since TB does not ask the server about the READ/WRITE permissions, it does not matter what the server is. The server is modified Cyrus IMAP, which allows unauthenticated WebDAV requests.

Comment 4

[Lasana Murray]

Attachment: Bug 1722730 - Fix typo preventing read-only CardDav address books from being detected. r=darktrojan

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1b67c5169475
Fix typo preventing read-only CardDav address books from being detected. r=darktrojan

Comment 6

[Magnus Melin [:mkmelin]]

Please request 91 uplift.

Comment 7

[Lasana Murray]

Comment on attachment 9237805 [details]
Bug 1722730 - Fix typo preventing read-only CardDav address books from being detected. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Carddav books will not be recognized as read-only
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky): Low risk, fixes a typo previously made.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9237805 [details]
Bug 1722730 - Fix typo preventing read-only CardDav address books from being detected. r=darktrojan

[Triage Comment]
Approved for esr91

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 91.2.0:
https://hg.mozilla.org/releases/comm-esr91/rev/eb7538d7e3ca