Closed Bug 1725088 Opened 3 years ago Closed 3 years ago

Work out what tree-listbox should do when there are 0 rows

Categories

(Thunderbird :: General, enhancement)

enhancement

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
93 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The listbox was conceived for a use case where there are always rows. Now we want to use it for uses where there might be zero rows.

If there are zero rows to begin with, or all rows are removed, selectedIndex becomes -1. If a row is then added, it becomes selected automatically.
This patch also handles what happens if the selected row is removed. Selection moves to

  • the nearest remaining ancestor, or if there isn't one
  • the top-level row preceding the removed rows, or if there isn't one
  • the first top-level row.
Attachment #9235754 - Attachment description: WIP: Bug 1725088 - Define the behaviour of tree-listbox when there are 0 rows. r=mkmelin → Bug 1725088 - Define the behaviour of tree-listbox when there are 0 rows. r=mkmelin
Attachment #9235755 - Attachment description: WIP: Bug 1725088 - Move tree-listbox event listeners and observers out of connectedCallback. r=mkmelin → Bug 1725088 - Move tree-listbox event listeners and observers out of connectedCallback. r=mkmelin

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/487fc069e82d
Define the behaviour of tree-listbox when there are 0 rows. r=mkmelin
https://hg.mozilla.org/comm-central/rev/df08e87957ed
Move tree-listbox event listeners and observers out of connectedCallback. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: