1726360 - [Wayland] Async clipboard slow paste

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Laurențiu Nicola]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Enable widget.wayland.async-clipboard.enabled, copy some text to clipboard, paste in Firefox.

Actual results:

Paste takes about 500 ms.

Expected results:

Paste is instantaneous.

Actually, async paste seems pretty counter-intuitive, and I assume it only gets worse for images.

Comment 1

[Laurențiu Nicola]

Oh, there's even a sleep call in there.

Comment 2

[Laurențiu Nicola]

Attachment: Clipboard log

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1726360 [Wayland] Add widget.wayland.async-data-transfer.enabled static pref, r?jhorak

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1726360 [Wayland] Update clipboard timeouts, r?jhorak

• Set kClipboardTimeout to 1 sec to allow image pastes.
• Add kClipboardFastIterationNum to control how many event loop iterations will be done without sleep.

Depends on D123608

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1726360 [Wayland] Sync clipboard update, r?jhorak

• Allow async data transfer when widget.wayland.async-data-transfer.enabled static is set.
• Return early when fast track request number does not match and don't process such events.
• Use kClipboardFastIterationNum to process fast iterations.

Depends on D123609

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1726360 [Wayland] Async clipboard update, r?jhorak

• Return early when mClipboardRequestNumber does not match and we're getting old data.
• Implement kClipboardFastIterationNum to allow fast unthrottled iterations.

Depends on D123610

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1726360 [Wayland] D&D timeouts update, r?jhorak

• Expand NS_DND_TIMEOUT to 1 sec.
• Do first event loop iteration without timeout.

Depends on D123611

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/252a8a030a49
[Wayland] Add widget.wayland.async-data-transfer.enabled static pref, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/8b0f13706131
[Wayland] Update clipboard timeouts, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/f1a23246cda9
[Wayland] Sync clipboard update, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/f6a2a6120840
[Wayland] Async clipboard update, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/8dbac57c6d97
[Wayland] D&D timeouts update, r=jhorak

Comment 9

[Iulian Moraru]

Backed out for causing build bustages on nsClipboardWayland.cpp.

Push with failures

Failure log for Linux opt build
Failure log for Linux Shippable opt instr build

Backout link

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Updated, Thanks.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=102739ed612ab6510b353bb91db5e1ffed76c45c

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dd11cc27215
[Wayland] Add widget.wayland.async-data-transfer.enabled static pref, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/e01edd28ebcb
[Wayland] Update clipboard timeouts, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/0f4651d60548
[Wayland] Sync clipboard update, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/de30a0b31900
[Wayland] Async clipboard update, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/84f73e40400b
[Wayland] D&D timeouts update, r=jhorak

Comment 12

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/0dd11cc27215
https://hg.mozilla.org/mozilla-central/rev/e01edd28ebcb
https://hg.mozilla.org/mozilla-central/rev/0f4651d60548
https://hg.mozilla.org/mozilla-central/rev/de30a0b31900
https://hg.mozilla.org/mozilla-central/rev/84f73e40400b

Comment 13

[Laurențiu Nicola]

I just tested this. With widget.wayland.async-data-transfer.enabled disabled, paste works well.

With it enabled, it's sometimes as slow as before (generally after startup), but generally fast enough that I can't paste in the address bar, press Enter and see the browser load the previous page as it used to happen before this fix.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

We're moving to async clipboard by default (Bug 1729423).
widget.wayland.async-data-transfer.enabled is used by old (sync) clipboard just for data transfers so it should nor have any effect here.