1726606 - Default FFHCM to "never" on MacOS

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Morgan Reschenberg [:morgan]]

As above.

Recently, we decided to default FFHCM to "with HCM themes" on MacOS, but this has caused some confusion for users for whom "increase contrast" previously had no effect on FF HCM. We should revert (and uplift) this change, restoring the UX we had before.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1726606: Default browser.display.document_color_use to 1 on MacOS r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1db4e355714
Default browser.display.document_color_use to 1 on MacOS r=emilio

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b1db4e355714

Comment 4

[Morgan Reschenberg [:morgan]]

Comment on attachment 9237089 [details]
Bug 1726606: Default browser.display.document_color_use to 1 on MacOS r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: MacOS users running with "Increase Contrast" set at the OS level will continue to have FF HCM enabled by default.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Launch a clean profile in MacOS
  In about:preferences > Language and Appearance > Colors, verify the dropdown value is initially "Never".
  Navigate to data:text/html,<div style="background:green; border:10px solid blue;">hello world</div> and verify colors are visible (ie. not flattened to black and white)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch changes the default (but not necessarily current) value of a preference. Users still have the ability to change this value in about:preferences UI.
• String changes made/needed:

Comment 5

[Morgan Reschenberg [:morgan]]

Comment on attachment 9237089 [details]
Bug 1726606: Default browser.display.document_color_use to 1 on MacOS r?emilio

See form filled above :)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237089 [details]
Bug 1726606: Default browser.display.document_color_use to 1 on MacOS r?emilio

Approved for 92.0b7.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d22ad850557a

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 92.0b7 (20210822190301) and 93.0a1 (20210822212235) on macOS 10.15 and 11.5 ARM. The value from the drop down inside about:preferences > Language and Appearance > Colors is set to never and the blue/green colors from the attached test case are displayed as expected when using Increase Contrast.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9237089 [details]
Bug 1726606: Default browser.display.document_color_use to 1 on MacOS r?emilio

approved for 91.0.2

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/1aa232202866

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed using Firefox 91.0.2 (20210823123856) on macOS 10.15 and macOS 11.5 ARM. The value from the drop-down inside about:preferences > Language and Appearance > Colors is set to Never and the blue/green colors from the attached test case from comment 4 are displayed as expected when using Increase Contrast.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Hi Morgan, I believe we'll need this on ESR91 also? Can you please nominate if that's correct? No need to fill out the questionnaire again.

Comment 15

[Morgan Reschenberg [:morgan]]

Comment on attachment 9237089 [details]
Bug 1726606: Default browser.display.document_color_use to 1 on MacOS r?emilio

ESR Uplift Approval Request

see above

:)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237089 [details]
Bug 1726606: Default browser.display.document_color_use to 1 on MacOS r?emilio

Approved for 91.1esr.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/9e69a6210f88

Comment 19

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 91.1.0esr (20210901125518) on macOS 11.5 ARM and 10.15.