1718743 - [macOS] White artifacts with high contrast on dark theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Daniel Cicas [:dcicas], Release QA]

Attachment: imgpsh_fullsize_anim.png

Affected versions

• Nightly 91.0a1 (Build ID: 20210629214925)

Affected platforms

• macOS 11
  macOS 10.15

Steps to reproduce

1. Start Firefox.
2. Enable dark theme on OS level.
3. Enable dark theme for Firefox.
4. Enable High Contrast.
5. Visit www.youtube.com and select a video.

Expected result

• There are no visual artifacts on dark mode with High Contrast.

Actual result

• There are several white visual artifacts.

Regression range

• First bad: 2021-06-03
• Last good: 2021-06-02
• Pushlog: https://hg.mozilla.org/integration/autoland/log?rev=52ed1b7f1fb09ac54ca8fda70201a5258fd00647
• Potentially regressed by: https://bugzilla.mozilla.org/show_bug.cgi?id=1713015

Additional notes

• The white background while in dark theme is a separate bug 1709508

Comment 1

[Daniel Cicas [:dcicas], Release QA]

Attachment: Screenshot 2021-06-29 at 18.09.23 (1).png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1713015

Comment 3

[Morgan Reschenberg [:morgan]]

I think the addons issue is a CSS one -- we don't have the same problem in preferences.

I can reproduce the youtube issue on 89 without MacOS HCM enabled (just about:preferences > always). Does this reproduce on windows, too? (I don't have a machine to test :( )

Comment 4

[Pascal Chevrel:pascalc]

Daniel, could you answer Morgan's question above? Thanks

Comment 5

[Daniel Cicas [:dcicas], Release QA]

Attachment: youtube_high_contrast_issue.JPG

Hello,

The youtube issue, on windows appears as in the attached screenshot. I checked on 91.0b1, 90.0, 89.0 and 92.0a1 (Build ID: 20210712215604). On Windows the issue seems present as well because of the black masks around the buttons.

Comment 6

[Morgan Reschenberg [:morgan]]

Removing the above regression, since this affects both windows and mac while the tagged bug was a mac-specific change.

Comment 7

[Julien Cristau [:jcristau]]

Bad bot.

Comment 8

[Sarah Clements [:sclements]]

Attachment: Screen Shot 2022-02-14 at 5.26.44 PM.png

Comment 9

[Sarah Clements [:sclements]]

I'm not seeing this issue on YouTube on the latest Firefox (v97) on macOS - see above screenshot. And I'm not entirely sure what's wrong in the second screenshot (of the themes tab). My guess is the muted icon on one of the tabs... but that looks the same in dark mode with and without high contrast.

It doesn't look like Daniel is around anymore... is anyone able to add insight about this. And to verify this works fine on Windows too?

Comment 10

[Sarah Clements [:sclements]]

:aflorinescu would you be able to help me track down someone from QA who can help?

Comment 11

[Adrian Florinescu [:aflorinescu]]

Attachment: dark-highc.jpg

(In reply to Sarah Clements [:sclements] from comment #10)

:aflorinescu would you be able to help me track down someone from QA who can help?

I can confirm that I get the same results as on comment 9 on Mac Os 11.5.1 with Nightly 99.0a1 (2022-02-14) and Release 97.0 and I can see no artefacts anymore. ( mac contrast settings surely are a bit weird)

However, on Windows, the issue can still be reproduced (Nightly 99.0a1 (2022-02-14) and Release 97.0): see attached image. So maybe, spin the Windows issue into a separate issue and mark this as verify? @Sarah, thoughts?

Comment 12

[Sarah Clements [:sclements]]

Adrian, I've created a new issue with bug 1755713 as you've suggested. However, I don't have access to a PC at the moment. Could you please help to fill out any missing details in the new bug and to add screenshots of the about:addons page and you tube?

Comment 13

[Sarah Clements [:sclements]]

Attachment: Screen Shot 2022-02-16 at 3.58.06 PM.png

about:addons page on Mac is also fixed

Comment 14

[Sarah Clements [:sclements]]

I used mozregression to find the fix for the youtube icons on macOS and it points to the patch for bug 1726606.
The about:addons icons was fixed by the patch for bug 1723938.

Comment 15

[Adrian Florinescu [:aflorinescu]]

Sure, I'll move the NI in bug 1755713.