1726817 - Focus [Continue in Troubleshoot Mode] button and make it the default button in the dialog

Status: NEW

(Thunderbird :: Preferences, enhancement)

Description

[Thomas D. (:thomas8)]

STR

1. hold shift while starting TB to enter troubleshoot mode
2. observe focus when "Thunderbird troubleshoot mode" dialog is shown
3. Press Enter

Actual result

• initial focus on "Disable all addons (permanently)": that's confusing, because that's not what most users want or need
• no default button, so pressing Enter does nothing
• main action, "Continue in Troubleshoot mode", unnecessarily clumsy to get with keyboard

Expected result

• don't irritate with focus on peripheral action checkbox which is mostly unwanted
• Focus the most likely action, "Continue in Troubleshoot mode"
• Make that default button, too

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Thunderbird Troubleshoot Mode dialog with initial focus on `Disable all add-ons (permanently)`

.

Comment 2

[Alessandro Castellani [:aleca]]

Yeah, I think these are sensible changes.
We have full control on that dialog so it shouldn't be a problem: https://searchfox.org/comm-central/rev/6fda60c4093536d201df8d57e34b5ec269bf3625/mail/base/content/troubleshootMode.xhtml

Question for screen reader users?
Should the focus be on the body of the dialog so screen readers can pick it up? My doubt is that if we move the focus on a specific element does it mean only that element is read out loud and the rest of the dialog is ignored?

Comment 3

[Thomas D. (:thomas8)]

Valentin, can you help us with the question below?

(In reply to Alessandro Castellani [:aleca] from comment #2)

Question for screen reader users?
Should the focus be on the body of the dialog so screen readers can pick it up? My doubt is that if we move the focus on a specific element does it mean only that element is read out loud and the rest of the dialog is ignored?

Comment 4

[Thomas D. (:thomas8)]

Hi Lilian, this might be an interesting little thing for you to fix! I've asked Alex for mentoring, so he'll be there to help you if you need help, and his response times are normally very good ;-) There's a starting point in code, see below. What do you think?

(In reply to Alessandro Castellani [:aleca] from comment #2)

Yeah, I think these are sensible changes.
We have full control on that dialog so it shouldn't be a problem: https://searchfox.org/comm-central/rev/6fda60c4093536d201df8d57e34b5ec269bf3625/mail/base/content/troubleshootMode.xhtml

Comment 5

[Valentin Villenave]

(In reply to Alessandro Castellani [:aleca] from comment #2)

Should the focus be on the body of the dialog so screen readers can pick it up?

If the focus is on the “Continue” button, the body should still be read until
“You can make some or all of these changes permanent”. As long as that’s the
case, I think we can live with skipping the two checkboxes by default.

(I was initially reminded of bug 1732850, where giving the focus to the first checkbox
would make a lot of sense, but that’s actually a different situation here, not to mention
a different kind of dialog.)

Comment 6

[Liscare]

Hi Thomas, thank you for pinging me on this bug, I take it.

Comment 7

[Thomas D. (:thomas8)]

(In reply to Liscare from comment #6)

Hi Thomas, thank you for pinging me on this bug, I take it.

That's great news, Lilian!

Comment 8

[Liscare]

Attachment: Bug 1726817 - Focus on Continue button in troubleshoot mode dialog. r=aleca

Comment 9

[Thomas D. (:thomas8)]

This whole dialog (see comment 1) is pretty confusing, because it's non-trivial to understand how the checkboxes will interact with the two buttons, and the consequences of using either aren't well explained. I think we could disambiguate this using radio boxes for the two main choices, and explaining each option better.

Alex, what do you think?

---

Thunderbird Troubleshoot Mode

Use Thunderbird troubleshoot mode to find out if problems are caused by your add-ons or customizations.

(◉) Start Thunderbird in troubleshoot mode (recommended). Your add-ons and customizations will be temporarily disabled until you restart Thunderbird again. ...disabled, but you can easily return to your original configuration with another restart.

( ‎‏‏‎ ‎‏‏‎) Make the following troubleshoot settings permanent and start Thunderbird:
‎‎‎‎‎‎‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎[ ] Disable all add-ons
‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎[ ] Reset toolbars and controls

Continue Cancel

---

Comment 10

[Alessandro Castellani [:aleca]]

This is a very strange dialog indeed.
Do we have any indication why 2 buttons were originally implemented? Just bad UX, or any other reason?

I like your suggestion, but the wording should be changed slightly.

---

Thunderbird Troubleshoot Mode

Start Thunderbird in Troubleshoot Mode to find out if problems are caused by your add-ons or customization.

(◉) Temporarily disable add-ons and customization.
‎‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎‏‏‎ Your settings will be restored on the next restart.

( ) Make the following changes permanent:
‎‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎[ ] Disable all add-ons
‏‏‎ ‎‏‏‎ ‎‏‏‎ ‎‏‏‎[ ] Reset toolbars and controls

CONTINUE CANCEL

---