1732850 - Accessibility regression in “Remove account” dialog box

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Valentin Villenave]

Attachment: Capture du 2021-09-28 09-12-53.png

When removing an account, the “Remove account” dialog opens.
The focused used to be on the “Remove” button (at least for Chat
accounts); that’s no longer the case. For Chat accounts, it’s on the
“More info” button; for Mail and Feed accounts, it’s on the “Remove
message data” check box. (I’m unclear as to whether that’s the
desired behavior.)

Thing is, when it opens there’s absolutely no way of visually knowing
where the focus actually is. Once you hit Tab and then <shift>Tab,
the focus does appear.

Comment 1

[Valentin Villenave]

Attachment: Capture du 2021-09-28 09-25-45.png

Comment 2

[Valentin Villenave]

See also bug 1728141.

Comment 3

[Valentin Villenave]

(This isn’t correlated with the graphical theme in use; I can reproduce it with any GTK theme.)

Comment 4

[Valentin Villenave]

Also, is it normal that the “Cancel” button is printed differently from the others?
As it is, it may look like that button has the focus instead of the actual focused one.

Comment 5

[Magnus Melin [:mkmelin]]

Cancel is the default (therefore visually different), and "always" was: https://searchfox.org/comm-central/rev/c4e0d3cf67130be7f046fc18aa4731b4ab552676/mailnews/base/prefs/content/removeAccount.xhtml#24
But I can confirm for chat accounts that somehow doesn't happen.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1732850 - Set initial focus in Remove Account dialog. r=mkmelin

This function is only used elsewhere by commonDialog.js, and it seems a bit of a hack, but if it's good enough for the there...

Comment 7

[Valentin Villenave]

Thanks! See also bug 1732860, which appears to reproduce part of the problem discussed here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/835d5553ba30
Set initial focus in Remove Account dialog. r=mkmelin

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9243183 [details]
Bug 1732850 - Set initial focus in Remove Account dialog. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): dunno
User impact if declined: focus is on the wrong button in a dialog
Testing completed (on c-c, etc.): in 94
Risk to taking this patch (and alternatives if risky): none

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9243183 [details]
Bug 1732850 - Set initial focus in Remove Account dialog. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/84042b43df53