1727263 - Port bug 1724194: ensure close button is visible in findbar

Status: VERIFIED FIXED

(Thunderbird :: Upstream Synchronization, task)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1727263-findbar-close.patch

Without this patch the close button isn't shown.

I also unified the rules to the shared file. We don't need special background colours on some platforms.

Comment 2

[Richard Marti (:Paenglab)]

Ah, forgot: this is a port of https://hg.mozilla.org/mozilla-central/rev/01b63399f2759e86ac941b498e6dc8d4fa532caf

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9237630 [details] [diff] [review]
1727263-findbar-close.patch

Review of attachment 9237630 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx! r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

I'm confused, this already landed.
https://hg.mozilla.org/comm-central/rev/90453540e868ddd5de133a7e4cd371cb80d6b185

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9237630 [details] [diff] [review]
1727263-findbar-close.patch

The m-c bug 1724194 has a ESR only uplift request. Only asking for ESR too.

[Approval Request Comment]
User impact if declined: close button on findbar will be hidden
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low, the patch is needed when the m-c patch lands

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9237630 [details] [diff] [review]
1727263-findbar-close.patch

And now is beta added too.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9237630 [details] [diff] [review]
1727263-findbar-close.patch

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 92.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/e92df8db9e9f

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9237630 [details] [diff] [review]
1727263-findbar-close.patch

[Triage Comment]
Approved for esr91

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 91.1.0:
https://hg.mozilla.org/releases/comm-esr91/rev/b832988b0f0f

Comment 11

[WaltS48 [:walts48]]

Verified testing the 91.1.0 release candidate on Windows 10.