1724194 - Close button disappears when reaching the end of the page

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Marco Castelluccio [:marco]]

STR:

1. Load https://github.com/mozilla/mozci/commit/885bce479374310ec232a104740309cbdba2b813
2. Type "mozilla"
3. Press ENTER to go to the next result, press ENTER again to reach the end of the page and surpass it

The X button at the far right of the Find Toolbar disappears, probably it overflows on the right.

Comment 1

[Marco Castelluccio [:marco]]

Current regression range I've found: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=71b483d7ca079428ccc968273ad25f1f1d9ba7a2&tochange=aa432f04a7da3f25eea116cd5548bc9c8554f18c.

It's a bit cumbersome to narrow it down because in this range the close button at some point was moved to the left, and then that change was reverted.

Comment 2

[Marco Castelluccio [:marco]]

Updated regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7bff3dc37b071d5272e2d445a0bfcbe21aabd38d&tochange=aa432f04a7da3f25eea116cd5548bc9c8554f18c.

It's very likely one of bug 1703337, bug 1702350, or bug 1690334.

Comment 3

[Marco Castelluccio [:marco]]

I've noticed that, in the period while the close button was on the left, the bug is still reproducible by looking at whether the "Reachend end of page, continued from top" text overflows.

By keeping browser.proton.enabled set to True during the bisection (otherwise it will end up on the "Enable Proton" patch), I've narrowed it down to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a63d3c92f0ac43f830b46c17a0178fbe6e635a56&tochange=48b9f07a9a021b8c2cc8f5feebe641ff5a34a52c.

So it looks like this was caused by bug 1690334.

Comment 4

[Emma Malysz]

I'll look into it this week

Comment 5

[Julien Cristau [:jcristau]]

Hi Emma, did you have a chance to look at this?

Comment 6

[Emma Malysz]

Attachment: Bug 1724194: ensure close button is visible in findbar

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01b63399f275
ensure close button is visible in findbar r=jaws

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/01b63399f275

Comment 9

[Richard Marti (:Paenglab)]

Is it planned to uplift to ESR-91? This would be a big help for Thunderbird.

Comment 10

[Julien Cristau [:jcristau]]

for comment 9.

Comment 11

[Emma Malysz]

Comment on attachment 9237580 [details]
Bug 1724194: ensure close button is visible in findbar

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Helpful for thunderbird
• User impact if declined: Close button is not visible for smaller windows
• Fix Landed on Version: 93
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes
• String or UUID changes made by this patch: n/a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9237580 [details]
Bug 1724194: ensure close button is visible in findbar

Approved for 92.0b9 and 91.1esr.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/37ea3067e389

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f423e9ee75f4

Comment 15

[Bogdan Maris, Desktop QA]

Reproduced the initial issue using old Nightly from 2021-08-05, verified that using latest builds Nightly, Beta and 91esr across platforms (Windows 10, Ubuntu 18.04 and macOS 11.5 - even though on mac the close icon is in the far left of the find bar).

Comment 17

[Daniel Bodea [:danibodea]]

The fix in bug 1728368 enhances the fix of this issue as the "X" button is now always displayed, indifferently to how narrow the browser window is.
This fix is only applied in Nightly v93.0a1 from 2021-09-03, but an uplift was requested.

Comment 21

[Urmas]

NOT FIXED as of 95.0.2

Comment 22

[Julien Cristau [:jcristau]]

Please file new bugs for remaining issues.

Comment 23

[Harry Twyford]

(In reply to Urmas from comment #21)

NOT FIXED as of 95.0.2

Yes, this fix was later regressed. I just landed a fix for it this morning in bug 1745455.