1727366 - Disabled status of message filters not shown in list of filters

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[reg_bugzilla.mozilla.org]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36

Steps to reproduce:

Open Message Filter
Toggle "enabled" state for some filters by clicking the checkmark
Close Message Filter
Open Message Filter again

Actual results:

all the previous disabled Message Filters were enabled again

Expected results:

Thunderbird should save the enabled/disabled state of the message filters after closing the Message Filter window.

Comment 1

[reg_bugzilla.mozilla.org]

Further infos:
Win 10 Pro 64 bit, Thunderbird 91.0.2 64 bit
Tried it with troubleshoot mode and created a new profile, bug persists in both cases.

Comment 2

[Wayne Mery (:wsmwk)]

I see this with 92.0b3. Nothing in error console.

This could lead to dataloss, so pretty serious.

I think I have disabled filters that are not being listed, so perhaps it is partly a display issue?

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=563485d4bac29add2876f31fb05e5b110ffd1b43&tochange=f734b3219c1da7ffa0f9c76c143ed8867a76e7f3
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=269819a25f93255894887689cac0df8e7dbf3cb5&tochange=b740f950e4971e9e17c16b0e19e569cd3b07ceb5

Regression window(with browser.proton.enabled = true):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=cb9f2cf495acec1c430981548787c7382bff209a&tochange=0870a62e5554cff44c2c2a1d74df29948027ef34
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8fdbcaa80217ed7e511f08f7aab4b8bb6fbae77c&tochange=6264f13d54a1caa4f5b60303617a819efd91b8ee

Suspect : Bug 1697315 or Bug 1697210

Comment 4

[Wayne Mery (:wsmwk)]

I looked at my msgfilters.dat file and I see rules with enabled="no". So it is definitely a display issue.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1727366-filter-checked.patch

The toolkit rule check only on [checked] and the checkbox uses checked="false". With this the rule is always true.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9237994 [details] [diff] [review]
1727366-filter-checked.patch

Review of attachment 9237994 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking care of this.
Things will be way easier once we get rid off of all these XUL elements.

Comment 7

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/000dd197a381

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9237994 [details] [diff] [review]
1727366-filter-checked.patch

[Approval Request Comment]
User impact if declined: disabled filters are still shown as active
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low, it's a simple JS change

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9237994 [details] [diff] [review]
1727366-filter-checked.patch

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 92.0b5: (fixed typo)
https://hg.mozilla.org/releases/comm-beta/rev/8f094a5c86b6

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9237994 [details] [diff] [review]
1727366-filter-checked.patch

[Triage Comment]
Approved for esr91

Comment 14

[Rob Lemley [:rjl]]

https://hg.mozilla.org/releases/comm-esr91/rev/aa6e9effa828