1697210 - radio buttons can have uneven eye and border with non-native theme

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot with uneven radio button

Firefox 88.0a1 20210309094921 on Windows 8.1, device pixel ration 1.25

Radio buttons can have an uneven eye and border (border is stronger on the right than on the left).

Steps to reproduce: Open an open Phabricator revision and call its Lando page.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1697210 - Paint radio checkmark as part of nsNativeBasicTheme::PaintRadioControl, and snap the checkmark inset. r=mstange

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1697210 - Make the checkbox / radio rect paint to an exact number of device pixels. r=mstange

This used to be the case (for default-sized radio buttons anyways)
before bug 1693688 (since GetMinimumWidgetSize returns a
LayoutDeviceIntSize, which rounded).

With the previous patch we never see uneven borders, but the radio might
be e.g. one pixel taller than its width, which also looks odd. So
truncate to device pixels to avoid it.

Depends on D107809

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1697210 - Make disabled checkbox / radio buttons do the right thing when painted with non-webrender. r=mstange

data:text/html,<input type=checkbox checked disabled>

Has a weird double border because the DrawTarget codepath fills and
strokes the same path, which is fine if the border is opaque, but not
otherwise.

Since this is the only use for a non-opaque border that we have, I
think, dealing with it on the caller seems a bit simpler. But let me
know if you want me to fix it more generally in
PaintRoundedRectWithRadius. I think for the semi-transparent border
case we'd need to create two paths, one for the background and one for
the border, which is a bit unfortunate.

The webrender codepath does the right thing, but of course that doesn't
get used for checkboxes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e76b9c534c7
Paint radio checkmark as part of nsNativeBasicTheme::PaintRadioControl, and snap the checkmark inset. r=mstange
https://hg.mozilla.org/integration/autoland/rev/be1d1b00f78d
Make the checkbox / radio rect paint to an exact number of device pixels. r=mstange

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3466de88cadc
Make disabled checkbox / radio buttons do the right thing when painted with non-webrender. r=mstange

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1e76b9c534c7
https://hg.mozilla.org/mozilla-central/rev/be1d1b00f78d
https://hg.mozilla.org/mozilla-central/rev/3466de88cadc