1729232 - Checking the spelling of a misspelling of the word "fonctionnalité" using the french dictionnary crashes firefox

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Baptiste]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

I had written "functionality" in a label name field on trello.com and tried right clicking to spellcheck it (while having the language to check for set to french).
(I have found afterward that it doesn't only happen on trello, but on any website where you can write)
(using Firefox Nightly 93.0a1)

Actual results:

The browser froze and eventually crashed.

Expected results:

The context menu should have popped up with the correct spelling for "fonctionnalité"

Comment 1

[Alice0775 White]

Nightly 93.0a1 en-US build hangs with French spelling dictionary.

Profiler log:
https://share.firefox.dev/3jTkUkN

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]: Browser hangs when checking spelling in French dictionary

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f1086c70c60e04d45640803305e6839b8b45fb14&tochange=24648ecd582b0b03835cbaff87e5b01b65a41612

Comment 3

[Pascal Chevrel:pascalc]

Tracking for 93. Baptiste, can you put in this bug comments a crash ID from the about:crashes page caused by this bug if there is one created when the crash happens? Thanks

Comment 4

[Benjamin Beurdouche [:beurdouche]]

I could reproduce the hang multiple times but not the crash.

Comment 5

[Baptiste]

(In reply to Pascal Chevrel:pascalc from comment #3)

Tracking for 93. Baptiste, can you put in this bug comments a crash ID from the about:crashes page caused by this bug if there is one created when the crash happens? Thanks

unfortunately, the browser doesn't create a crash report on my side.

Comment 7

[Shravan Narayan]

Attachment: Bug 1729232 - Update wasm2c rt to ensure correct hunspell timeout r=glandium

Comment 8

[Mike Hommey [:glandium]]

Can you request an uplift to beta? Likewise for D124308 in 1727266

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fabd17b76fd6
Update wasm2c rt to ensure correct hunspell timeout r=glandium

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fabd17b76fd6

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:shravanrn, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Pascal Chevrel:pascalc]

Please request an uplift to beta, thanks!

Comment 13

[Pascal Chevrel:pascalc]

Mike, do you want to request uplift to beta as the reviewer or should we ship this fix in 94 only? Thanks

Comment 14

[Mike Hommey [:glandium]]

Comment on attachment 9240210 [details]
Bug 1729232 - Update wasm2c rt to ensure correct hunspell timeout r=glandium

Beta/Release Uplift Approval Request

• User impact if declined: Hangs/crashes in some uses of the spellchecker
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: 1727266 (only D124308)
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix for a correctness issue when transforming seconds to nanoseconds, and an extra change for error logging on Windows.
• String changes made/needed: N/A

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9240210 [details]
Bug 1729232 - Update wasm2c rt to ensure correct hunspell timeout r=glandium

Approved for 93 beta 3, thanks.

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/83a58d7fd8e3