1729472 - Perma devtools/client/performance-new/test/browser/browser_interaction-between-interfaces.js | undefined assertion name - missing "Native Stacks" when Gecko 94 merges to Beta on 2021-10-04

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

The issue only affects devtools on macOS - in the Beta config, DevEdition is not affected.

Native Stacks is missing from these:

12:21:38 INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_interaction-between-interfaces.js | undefined assertion name - Got "Interval: 2 ms\nThreads: GeckoMain, Compositor, Renderer, DOM Worker\nScreenshots\nJavaScript\nNative Leaf Stack\nCPU Utilization", expected "Interval: 2 ms\nThreads: GeckoMain, Compositor, Renderer, DOM Worker\nScreenshots\nJavaScript\nNative Leaf Stack\nNative Stacks\nCPU Utilization"
12:21:38 INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_interaction-between-interfaces.js | undefined assertion name - Got "Interval: 2 ms\nThreads: GeckoMain, Compositor, Renderer, DOM Worker, StyleThread\nScreenshots\nJavaScript\nNative Leaf Stack\nCPU Utilization", expected "Interval: 2 ms\nThreads: GeckoMain, Compositor, Renderer, DOM Worker, StyleThread\nScreenshots\nJavaScript\nNative Leaf Stack\nNative Stacks\nCPU Uti
12:21:38 INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_interaction-between-interfaces.js | undefined assertion name - Got "Interval: 2 ms\nThreads: GeckoMain, Compositor, Renderer, DOM Worker\nScreenshots\nJavaScript\nNative Leaf Stack\nCPU Utilization", expected "Interval: 2 ms\nThreads: GeckoMain, Compositor, Renderer, DOM Worker\nScreenshots\nJavaScript\nNative Leaf Stack\nNative Stacks\nCPU Utilization"
12:21:38 INFO - TEST-UNEXPECTED-FAIL | devtools/client/performance-new/test/browser/browser_interaction-between-interfaces.js | undefined assertion name - Got "Interval: 2 ms\nThreads: GeckoMain, Compositor, StyleThread, DOM Worker\nScreenshots\nJavaScript\nNative Leaf Stack\nCPU Utilization", expected "Interval: 2 ms\nThreads: GeckoMain, Compositor, StyleThread, DOM Worker\nScreenshots\nJavaScript\nNative Leaf Stack\nNative Stacks\nCPU Utilization"

Comment 1

[Julien Wajsberg [:julienw]]

Changing severity to S4 because users are not impacted.

Comment 2

[Julien Wajsberg [:julienw]]

Here is a try for early beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48c0e3d22a1454e86682bd69f260b47223115db
And another one for late beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69c79fa527ffd152117a959d9257d3df733350ce

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: Bug 1729472 - [devtools performance] Adapt the multi-panel interaction tests so that they work in environments where some features are missing r=jdescottes!

Comment 4

[Julien Wajsberg [:julienw]]

(In reply to Julien Wajsberg [:julienw] from comment #2)

Here is a try for early beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48c0e3d22a1454e86682bd69f260b47223115db
And another one for late beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=69c79fa527ffd152117a959d9257d3df733350ce

These try builds are completely busted for unrelated reasons... Is that known Sebastian? Any idea to fix this on my end?

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The patch from bug 1729689 is needed to unbust these simulations (should be in central on Friday).

Comment 6

[Julien Wajsberg [:julienw]]

Thanks, I updated to latest m-c and retried again in https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a0384ac6fbe67c1a652c6768f66b8147149d8d4

Comment 7

[Julien Wajsberg [:julienw]]

Try after rebasing on top of latest central (because I updated some tests in this area): https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab3624bf3243c1c203f6d6d51cf5e8bef5a101db

They're not exactly the same tests (they're not "shippable"), but the tests in the "debug" build were showing the same issues previously.

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

Applying the patch in latest beta sim made the failures go away

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/596b3eff1c15
[devtools performance] Adapt the multi-panel interaction tests so that they work in environments where some features are missing r=jdescottes

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e862f7b2cd6
Backed out changeset 596b3eff1c15 for causing mochitest failures on browser_headless_screenshot_1/2.js. CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11d3a5026dea
[devtools performance] Adapt the multi-panel interaction tests so that they work in environments where some features are missing r=jdescottes. CLOSED TREE

Comment 12

[Cristian Tuns]

The issue wasn't from there it got relanded.

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/11d3a5026dea

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-beta simulation.