1729714 - Notification box is not easily focused through the keyboard.

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

The #compose-notification-bottom cannot be easily reached using a keyboard. Specifically, the message body absorbs any Tab presses, and a keyboard user must rely on using F6/Ctrl+Tab to jump the jump the focus forward. But this currently will skip to the status bar, or loop around to the contacts pane or "From" entry.

There is a current work around by using Shift+Tab and approaching from the other direction. However, we could easily extend the F6 behaviour to this bar as well.

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Should probably also review this section that handles Esc https://searchfox.org/comm-central/rev/fefc1c8a9f1910815604268b2c058303aa54f175/mail/components/compose/content/MsgComposeCommands.js#2819

Comment 2

[Thomas D. (:thomas8)]

(In reply to Henry Wilkes [:henry] from comment #1)

Should probably also review this section that handles Esc https://searchfox.org/comm-central/rev/fefc1c8a9f1910815604268b2c058303aa54f175/mail/components/compose/content/MsgComposeCommands.js#2819

Reviewing will be great, but imo we should keep the intended ux-efficiency functionality.

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Thomas D. (:thomas8) from comment #2)

Reviewing will be great, but imo we should keep the intended ux-efficiency functionality.

I didn't mean get rid of it. I have a suspicion that activeElement.classList.contains("messageCloseButton") is dead code because this is a class used in <notification> elements, but we use <notification-message> elements now. And I think activeElement.parentNode.parentNode.id == "msgSubject" is fragile, and might be broken. So its worth fixing this up at the same time since it falls under the same area of keyboard access.

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1729714 - Place the notification area in the compose focus cycle. r=aleca

Comment 5

[Henry Wilkes (they/them) [:henry-x]]

wontfix for 91 because this depends on changes in bug 1723757 that aren't in 91.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bd0dd175fffa
Place the notification area in the compose focus cycle. r=aleca