1729744 - Port bug 1718629: Handle Windows WM_NCHITTEST message for maximize button

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Richard Marti (:Paenglab)]

This is needed to enable the Snap Layouts menu under Windows 11 with draw in title bar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1729744-Win11-max-btn.patch

Port of https://hg.mozilla.org/mozilla-central/rev/e03c235c93c8.

Note that we implemented the titlebar differently and we have only one button that needs this attribute.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9240090 [details] [diff] [review]
1729744-Win11-max-btn.patch

Review of attachment 9240090 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks for taking care of this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0472ac1ad26
Port bug1718629: Handle Windows WM_NCHITTEST message for maximize button. r=aleca

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9240090 [details] [diff] [review]
1729744-Win11-max-btn.patch

[Approval Request Comment]
User impact if declined: needed to enable the Snap Layouts menu under Windows 11 with draw in title bar.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): safe

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9240090 [details] [diff] [review]
1729744-Win11-max-btn.patch

[Triage Comment]
Approved for ers91

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/5d654574d8ed