Closed Bug 1729877 Opened 4 years ago Closed 4 years ago

[XFA] Saved selections of checkboxes that are subsequently deselected appear as selected in print preview

Categories

(Firefox :: PDF Viewer, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
94 Branch
Tracking Status
firefox-esr78 --- disabled
firefox-esr91 --- fixed
firefox92 --- disabled
firefox93 --- verified
firefox94 --- verified

People

(Reporter: danibodea, Assigned: calixte)

References

Details

Attachments

(4 files)

+++ This bug was initially created as a clone of Bug #1723734 +++

Note

  • When the user loads a specific PDF file, selects some checkboxes, and then saves it, reopens it, deselects the previously made selections and goes into print preview, he will notice that the previously selected and saved, then currently deselected checkboxes are now incorrectly displayed as selected.

Affected versions

  • Beta v93.0b2

Affected platforms

  • all

Steps to reproduce

  1. Launch browser.
  2. Load the attached PDF file.
  3. Make some selections of the checkboxes on sections 3 subsection 19 (page 1).
  4. Save the PDF file.
  5. Reopen it.
  6. Deselect the checkboxes.
  7. Go into Print preview (CTRL+P).

Expected result

  • The checkboxes appear as deselected (correctly).

Actual result

  • The checkboxes appear as selected (incorrectly)

Regression range

  • Not a regression, but an implementation flaw.
  • Behavior was uncovered after the fix of bug 1723734.

Additional information

  • A workaround is to save the document with the deselections before printing it.
  • Considering there's a workaround, I'm setting the S3 seerity. Could also go with S2...
Summary: [XFA] Selections of checkboxes or radio buttons are not saved (or shown) correctly → [XFA] Saved selections of checkboxes that are subsequently deselected appear as selected in print preview

When the document is open the HTML counterpart of the checkbox has a checked attribute.
Then the user unchecks it which sets a flag to false in the annotationStorage.
When the user print it we get the original HTML so with the checked attribute but it isn't removed because of its new value from annotationStorage => bug.
So the fix is pretty simple: just remove the checked attribute when the value from the annotationStorage is xfaOff.

Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Priority: -- → P1
Attached file xfa_bug1729877.pdf

Add a version of the pdf with a checked checkbox

Commit merged into master by GitHub Authored by calixteman (calixteman)
Depends on: 1730725
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
QA Whiteboard: [pdf_xfa_generic]
Depends on: 1741445
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: