1730391 - Add removeBrowser helper for tabbrowser

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, task)

Description

[Ian Neal]

At the moment in tabbrowser.xml the code for destroying old/dead browsers is duplicated, it appears in 4 different places.
Whilst here exploit getNotificationBox helper to remove further duplication.
Also fixes a strict JS error.

Comment 1

[Ian Neal]

Attachment: 1730391-removeBrowser-25310.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): small
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9240794 [details] [diff] [review]
1730391-removeBrowser-25310.patch

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/55730e9b6a01
Add removeBrowser helper for tabbrowser. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a89321965eb3cc22e7a0cecc4ead41b5e77a3153
Add removeBrowser helper for tabbrowser. r=frg a=frg