Closed Bug 1730391 Opened 3 months ago Closed 2 months ago

Add removeBrowser helper for tabbrowser

Categories

(SeaMonkey :: Tabbed Browser, task)

Tracking

(seamonkey2.53? affected)

RESOLVED FIXED
seamonkey 2.92
Tracking Status
seamonkey2.53 ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.10)

Attachments

(1 file)

At the moment in tabbrowser.xml the code for destroying old/dead browsers is duplicated, it appears in 4 different places.
Whilst here exploit getNotificationBox helper to remove further duplication.
Also fixes a strict JS error.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): small
String changes made by this patch: none

Attachment #9240794 - Flags: review?(frgrahl)
Attachment #9240794 - Flags: approval-comm-release?
Attachment #9240794 - Flags: approval-comm-esr60?
Blocks: 1730392
Blocks: 1284504

Comment on attachment 9240794 [details] [diff] [review]
1730391-removeBrowser-25310.patch

LGTM

Attachment #9240794 - Flags: review?(frgrahl)
Attachment #9240794 - Flags: review+
Attachment #9240794 - Flags: approval-comm-release?
Attachment #9240794 - Flags: approval-comm-release+
Attachment #9240794 - Flags: approval-comm-esr60?
Attachment #9240794 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/55730e9b6a01
Add removeBrowser helper for tabbrowser. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Whiteboard: SM2.53.10
Target Milestone: --- → seamonkey 2.92
You need to log in before you can comment on or make changes to this bug.