1284504 - Responsive Design View does not load

Status: NEW

(SeaMonkey :: Tabbed Browser, defect)

Description

[Isaac Schemm]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 SeaMonkey/2.42
Build ID: 20160607174645

Steps to reproduce:

Downloaded a SeaMonkey 2.46a2 build from June 19th from https://l10n.mozilla-community.org/~akalla/unofficial/seamonkey/nightly/latest-comm-aurora-linux32/ and went to Tools > Web Development > Responsive Design View


Actual results:

Error to the terminal window:

A coding exception was thrown and uncaught in a Task.

Full message: TypeError: aWindow.gBrowser.getBrowserContainer is not a function
Full stack: ResponsiveUI@resource://devtools/client/responsivedesign/responsivedesign.jsm:168:20
Manager.runIfNeeded<@resource://devtools/client/responsivedesign/responsivedesign.jsm:77:12
TaskImpl.prototype._run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:310:39
TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:272:3
createAsyncFunction/asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:246:14
Manager.toggle@resource://devtools/client/responsivedesign/responsivedesign.jsm:63:7
toggle@chrome://navigator/content/webDeveloperOverlay.js:18:5
oncommand@chrome://navigator/content/navigator.xul:1:1


Expected results:

Responsive Design View should have loaded, as in Firefox

Comment 1

[Rainer Bielefeld]

a) REPRODUCIBLE with English SeaMonkey 2.46a1  (X11; Linux x86_64; rv:49.0)
   Gecko/20100101 Firefox/49.0 Build   20160527003002 (Default Classic Theme) 
   on VirtualBox Ubuntu 12.04 LTS:
   Proceed as per original report from Browser
   Expected: view as shown in screenshot 
   <https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode>
   Actual: Nothing happens.
b) REPRODUCIBLE with  English SeaMonkey (unofficial by frg) 2.47a1 (NT 6.1; Win64;
   x64; rv:50.0)  Gecko/20100101 Firefox/50.0 Build 20160628114904  
  (Default Classic Theme)  on German WIN7 64bit
c) Works fine with WIN FF 50.0a1 (2016-07-04)
d) neither Menu nor keyboard shortcut <shift+control+m> does work

Comment 2

[Frank-Rainer Grahl (:frg)]

I am getting an error in 2.45 too. Looks like the getBrowserContainer method is missing from our tabbrowser.xml. Might be a simple fix. Will inquire when I am back at the desktop.

FRG

Timestamp: 7/6/2016 8:02:58 PM
Error: A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Wed Jul 06 2016 20:02:43 GMT+0200 (W. Europe Standard Time)
Full Message: TypeError: aWindow.gBrowser.getBrowserContainer is not a function
Full Stack: ResponsiveUI@resource://devtools/client/responsivedesign/responsivedesign.jsm:168:20
Manager.runIfNeeded<@resource://devtools/client/responsivedesign/responsivedesign.jsm:77:12
TaskImpl_run@resource://gre/modules/Task.jsm:319:40
TaskImpl@resource://gre/modules/Task.jsm:280:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:254:14
Manager.toggle@resource://devtools/client/responsivedesign/responsivedesign.jsm:63:7
toggle@chrome://navigator/content/webDeveloperOverlay.js:18:5
oncommand@chrome://navigator/content/navigator.xul:1:1

Source File: resource://devtools/client/responsivedesign/responsivedesign.jsm
Line: 168
Source Code:
168

Comment 3

[Frank-Rainer Grahl (:frg)]

After porting getBrowserContainer I ran into the next error. Not that easy. Might be a Firefox only feature for the time being.

Comment 4

[Frank-Rainer Grahl (:frg)]

This would need a port of browser-gestureSupport.js among others.

Comment 5

[rsx11m]

There will be no 2.43 release. Is 2.44 affected?

Comment 6

[Frank-Rainer Grahl (:frg)]

2.43 and 2.44 do not have the devtools so they are not affected. 

I inquired further and tabbrowser.xml is missing some functionality. It might not be browser-gestureSupport.js after all. But also not easy to fix.

Comment 7

[Rainer Bielefeld]

(In reply to rsx11m from comment #5)
> There will be no 2.43 release. Is 2.44 affected?

As stated, this feature has been introduced to 2.45 by fix for "Bug 1223341 - Add the Firefox Devtools to the SeaMonkey UI", so this one can't affect 2.44. So (of course, I really tested) NOT reproducible  with unofficial (by frg)  SeaMonkey 2.44  Mozilla/5.0  (Windows NT 6.1; Win64; WOW64; rv:47.0)  Gecko/20100101 Firefox/47.0 Build 20160716132135  (Default Classic Theme) on German WIN7 64bit (SourceStamp=f5e801113dc7950616aa05089f477656b1ba6e16)

Comment 8

[rsx11m]

Then why did you set tracking-seamonkey2.44?  ;-)
Clearing.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 1284504-responsive-design-view.patch

WIP patch. Not taking the bug. If someomes wants to make this into a reviewable patch go ahead. Just clearing out some private patches I had in my tree. Seems to work but I bet at least a few other locations with id queries need to be changed too. The devtools need both the browserContainer and browserStack for the feature to work.

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1284504-responsive-design-view.patch

Works with more than one tab :)

Comment 11

[Isaac Schemm]

I found three issues (tested in comm-beta):

* If you open a new tab while responsive design view is active, something goes wrong and it becomes impossible to change the URL or do certain other things from the toolbar.
* The width of the responsive design view also changes the width of the tab bar and the devtools (if they are attached.)
* Small issue: the grippy is visible in the responsive design view toolbar, but doesn't do anything.

I don't know how to fix these, unfortunately (except that last one might just be some simple CSS.) A possible workaround would be to disable the tab bar and force the devtools to be detached, but that might be just as much work.

Changing resolution or user agent from the toolbar works as expected. :)

Comment 12

[Ian Neal]

Attachment: WIP-1284504-reponsive-design-view.patch

Unbitrotted version of the patch, still needs the theme stuff from:

• Bug 749628 - Implement a Responsive Design tool
• Bug 768442 - It's impossible to add a sidebar inside a tab