Support <input type=time> and <input type=date > in SeaMonkey
Categories
(SeaMonkey :: Themes, enhancement)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: frg, Assigned: frg)
References
(Blocks 1 open bug)
Details
(Whiteboard: SM2.53.10)
Attachments
(2 files, 2 obsolete files)
|
30.97 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
2.58 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
The support for these input types is unfortunately implemented in the backend (toolkit) and frontend (browser) so we need to port some parts of Bug 1288591 and followups. Not 100% a theme bug but close.
|
Assignee | |
Comment 1•3 years ago
|
||
wip patch. Modern needs further styling. Mostly copied from toolkit and merged with the current implementation.
|
|
Assignee | |
Comment 2•3 years ago
|
||
I think this one is reviewable to get it into 2.53.10. njsg did the Modern styling. Maybe the button bar is a bit bulky. Drop down marker is a ^ char and so a bit too high. When you select a month/year the popup has white chars in Windows but otherwise i think seem to fit Modern and Classic uses the toolkit style.
|
||
Comment 3•3 years ago
|
||
I didn't see it before, but there is a reset button, which is enabled/shown when the date input field has some value, but needs chrome://global/skin/icons/input-clear.svg which is not present in modern.
|
|
Assignee | |
Comment 4•3 years ago
|
||
New version with the clear icon. Think it can stay as is. Maybe change the color from gray to a Modern bluish?
Comment on attachment 9246159 [details] [diff] [review]
1730408-datetimepicker.patch
[Triage Comment]
LGTM r/a=me
Any further tweaks can go into a follow-up bug
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6c45a869f54d
Add picker for date and time inputs. r=IanN
|
|
Assignee | |
Comment 7•3 years ago
|
||
Followup. Add some dupes to the allowed dupes list.
trivial already in the prerelease for a week so r/a=me.
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/5b8474af1a33 Add duplicate modern theme files for datepicker to allow list. r=me
|
|
Assignee | |
Comment 9•2 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f223f6fc7f10ee2f726f2cbbbef044e54e85e7a3
Add picker for date and time inputs. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f71af85cca490a5d4509071802c53aafddeb0231
Add duplicate modern theme files for datepicker to allow list. r=me a=me
Description
•