Port gtests in TestHitTesting.cpp to mochitest
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox95 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(4 files)
TestHitTesting.cpp contains gtests whose specific purpose is to test the outcome of APZ's internal hit-test.
As of bug 1729118, the internal hit-test is going to be a test-only codepath, and there's not much point testing it specifically. It would be more useful to formulate the scenarios being tested as mochitests, which can exercise the WebRender hit-test that's actually used during production.
|
Assignee | |
Comment 1•3 years ago
|
||
More specifically, the tests which need porting are the subset of tests in TestHitTesting.cpp that use InternalHitTester.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D129333
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D129334
|
|
Assignee | |
Comment 5•3 years ago
|
||
In this case, the gtest is retained as it makes other assertions
(related to the APZC tree structure) which are useful. However,
it no longer makes hit-testing assertions, and no longer uses
InternalHitTester.
|
||
Comment 6•3 years ago
|
||
This is great! This change realizes me that I'd prefer mochitests since it can be easily visualized rather then gtests. That said, indeed it would be harder than gtest to debug it once it starts failing.
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2dd088a21a62 Port APZHitTestingTesterInternal.HitTesting1 to mochitest. r=hiro https://hg.mozilla.org/integration/autoland/rev/4e01993bc72b Port APZHitTestingTesterInternal.HitTesting2 to mochitest. r=hiro https://hg.mozilla.org/integration/autoland/rev/021e9580239e Port APZHitTestingTesterInternal.HitTesting3 to mochitest. r=hiro https://hg.mozilla.org/integration/autoland/rev/b56400c4afd8 Port APZHitTestingTesterInternal.ComplexMultiLayerTree to mochitest. r=hiro
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2dd088a21a62
https://hg.mozilla.org/mozilla-central/rev/4e01993bc72b
https://hg.mozilla.org/mozilla-central/rev/021e9580239e
https://hg.mozilla.org/mozilla-central/rev/b56400c4afd8
Description
•