1731700 - Simplify test usage of IAPZHitTester

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

In bug 1729118, I extracted an IAPZHitTester interface to encapsulate the implementation of the hit-testing used by APZ, with production code using a WebRender implementation, and APZ gtests using a test-only implementation.

Currently, the test-only implementation, InternalHitTester, is a "full-featured" hit test implementation that walks the hit testing tree; it's the same code that was used in production with Layers but factored out and moved into test code.

The only gtests that really need such a full-featured implementation are the ones in TestHitTesting.cpp, which will be ported to mochitest (where they can exercise the production WebRender hit-test codepath) in bug 1730606.

Once TestHitTesting.cpp is gone, the remaining gtests can be modified to use something simpler and more purpose-suited to the tests, and the "full-featured" InternalHitTester implementation can be removed.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Introduce MockHitTester. r=hiro

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Port TestSnapping to use MockHitTester. r=hiro

Depends on D129752

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Port TestSnappingOnMomentum to use MockHitTester. r=hiro

Depends on D129753

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Port TestEventRegions to use MockHitTester. r=hiro

Depends on D129754

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Port TestEventResult to use MockHitTester. r=hiro

Depends on D129755

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Port TestOverscroll to use MockHitTester. r=hiro

Depends on D129756

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Port TestScrollHandoff to use MockHitTester. r=hiro

Depends on D129757

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Do not use InternalHitTester in TestWRScrollData.cpp. r=hiro

These tests do not actually perform hit testing.

Depends on D129758

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1731700 - Remove InternalHitTester. r=hiro

Depends on D129759

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/455732aeb3ec
Introduce MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/e03f11e2b19a
Port TestSnapping to use MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/fdfcadbb16da
Port TestSnappingOnMomentum to use MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/5924e09c47c9
Port TestEventRegions to use MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/a635de37c836
Port TestEventResult to use MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/35d5bf32530f
Port TestOverscroll to use MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/08e3116697d7
Port TestScrollHandoff to use MockHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/0dec63bec4c1
Do not use InternalHitTester in TestWRScrollData.cpp. r=hiro
https://hg.mozilla.org/integration/autoland/rev/5e4df731f4d1
Remove InternalHitTester. r=hiro

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/455732aeb3ec
https://hg.mozilla.org/mozilla-central/rev/e03f11e2b19a
https://hg.mozilla.org/mozilla-central/rev/fdfcadbb16da
https://hg.mozilla.org/mozilla-central/rev/5924e09c47c9
https://hg.mozilla.org/mozilla-central/rev/a635de37c836
https://hg.mozilla.org/mozilla-central/rev/35d5bf32530f
https://hg.mozilla.org/mozilla-central/rev/08e3116697d7
https://hg.mozilla.org/mozilla-central/rev/0dec63bec4c1
https://hg.mozilla.org/mozilla-central/rev/5e4df731f4d1