173074 - print preview is enabled in the context menu for whitespace

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[timeless]

doron tested this using his untarnished mailnews client. 

the steps:
1. open mailnews to a folder
2. scroll to the very end of the thread pane and size the pane so that you can
see some whitespace
3. select a message in the thread pane
4. ctrl-click it to deselect it (problems start here)
5. right click whitespace in the threadpane (be sure not to click on a row that
has a message)
5' print preview was enabled

What should we do? don't enable print preview if zero items are selected.

I have a rewrite for the relevant file and I can fix this then if someone is
willing to review my patch.

Comment 1

[[e-mail]]

I assume the fix looks like this:
Index: mailContextMenus.js
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/resources/content/mailContextMenus.js,v
retrieving revision 1.37
diff -u -r1.37 mailContextMenus.js
--- mailContextMenus.js 14 Aug 2002 06:33:06 -0000      1.37
+++ mailContextMenus.js 11 Oct 2002 10:16:04 -0000
@@ -109,6 +109,7 @@
   EnableMenuItem("threadPaneContext-labels", (numSelected >= 1));
   SetupSaveAsMenuItem("threadPaneContext-saveAs", numSelected, false);
   SetupPrintMenuItem("threadPaneContext-print", numSelected, false);
+  SetupPrintMenuItem("threadPaneContext-printpreview", numSelected, false);
   SetupDeleteMenuItem("threadPaneContext-delete", numSelected, false);
   SetupAddSenderToABMenuItem("threadPaneContext-addSenderToAddressBook",
numSelected, false);
   SetupAddAllToABMenuItem("threadPaneContext-addAllToAddressBook", numSelected,
false);

Comment 2

[[e-mail]]

BTW, an easier way to demonstrate the problem is to use an empty folder.

Comment 3

[[e-mail]]

Yes, (numSelected == 1) works better :-)

Comment 4

[Steve Chapel]

Attachment: fix

This patch makes the Print Preview item available exactly when the Print item
is available.

Comment 5

[[e-mail]]

Comment on attachment 129677 [details] [diff] [review]
fix

... which is wrong, as I mentioned in comment 3.

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: fix 2

Comment 7

[[e-mail]]

*** Bug 191112 has been marked as a duplicate of this bug. ***

Comment 8

[Steve Chapel]

*** Bug 202786 has been marked as a duplicate of this bug. ***

Comment 9

[[e-mail]]

Comment on attachment 129808 [details] [diff] [review]
fix 2

Worse - now I don't get print preview at all in the message pane context menu.

Comment 10

[Steve Chapel]

> ... which is wrong, as I mentioned in comment 3.

So the issue is that the user can't get a print preview of more than one message
at a time, even though they can print more than one message at a time? That
sounds like a bug in the Print Preview feature to me.

Comment 11

[Steve Chapel]

Hmmm... on the other hand, Print Preview is disabled in the File menu if more
than one message is selected, so I suppose the context menu should behave them same.

Comment 12

[Steve Chapel]

Attachment: fix 3

This patch also disables Print Preview when multiple messages are selected,
just like Save As does. Additionally, it disables Print Preview when
right-clicking a link in a mail message, as it should.

Comment 13

[Steve Chapel]

Comment on attachment 129820 [details] [diff] [review]
fix 3

This patch prevents a bogus window and task from being created when Print
Preview is chosen when no message is selected. There is essentially no risk
because Print Preview is available through the File menu. Let's get this in for
1.5. The added lines can be commented out if anyone wants to fix the bugs this
depends on (the bogus window and task problem).

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 129820 [details] [diff] [review]
fix 3

1.5b shipped. moving approval request forward.

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 129820 [details] [diff] [review]
fix 3

a=asa (on behalf of drivers) for checkin to Mozilla 1.5

Comment 16

[[e-mail]]

Fix checked in.

Comment 17

[Steve Chapel]

Comment on attachment 129820 [details] [diff] [review]
fix 3

Let's get this in for 1.4.1, too. It's a pretty bad bug (creates a zombie task)
and is easy to trigger (start mailnews, right click on message window, and
select one of the two choices).

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 129820 [details] [diff] [review]
fix 3

too late for 1.4.1. if you'd like to see this in the next 1.4.x release please
set the approval1.4.2? flag.

Comment 19

[Mike Kaply [:mkaply]]

Comment on attachment 129820 [details] [diff] [review]
fix 3

a=mkaply