1731899 - [macOS] Missing popup buttons when accessing XMPP advanced options during account setup

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screen Shot 2021-09-21 at 2.46.33 PM.png

STR:

• Sign up with an XMPP account.
• Enter the password and click "Continue".
• The Advanced Options dialog appear.

The dialog doesn't have any visible button.
It's still possible to continue or cancel the process by pressing Enter or Esc on the keyboard.

Comment 1

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/log/tip/mail/components/im/content/imAccountWizard.xhtml - from bug 1703164 or bug 1731129, likely the former.

Comment 2

[Martin Giger [:freaktechnik]]

This issue affects the wizard in general, so moving to the Instant Messaging component.

I think this has been the case for at least half a year now, and as such affects 91 too, at least on Linux. the difference for me on Linux is that I can resize the wizard.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1731899 - Resize chat account setup wizard to fit protocol options. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e8dc0e6df88
Resize chat account setup wizard to fit protocol options. r=aleca

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9243937 [details]
Bug 1731899 - Resize chat account setup wizard to fit protocol options. r=aleca

[Approval Request Comment]
Regression caused by (bug #): unknown (if any)
User impact if declined: No visible buttons to continue during XMPP account setup. Especially problematic on platforms where the wizard can't be resized.
Testing completed (on c-c, etc.): Tested on c-c, beta
Risk to taking this patch (and alternatives if risky): At worst it would make the account wizard window higher when it's not needed.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9243937 [details]
Bug 1731899 - Resize chat account setup wizard to fit protocol options. r=aleca

[Triage Comment]
Approved for esr91

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.2.1:
https://hg.mozilla.org/releases/comm-esr91/rev/0ffd0ab0281f