convert top level <window> to <html> throughout the Thunderbird code base
Categories
(Thunderbird :: General, task)
Tracking
(thunderbird_esr78 wontfix)
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | wontfix |
People
(Reporter: mkmelin, Assigned: mkmelin)
References
(Blocks 1 open bug)
Details
(Keywords: leave-open)
Attachments
(8 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
Bug 1572062 converted the 3pane. For the most part styling has been adjusted already, and other preparations are now in place.
|
Assignee | |
Comment 1•3 months ago
|
||
|
|
Assignee | |
Comment 2•3 months ago
|
||
Depends on D113999
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b31114f27664
convert mail/base/content/messageWindow.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/8f8fada0529c
convert mail/components/compose/content/messengercompose.xhtml to top level <html>. r=henry
|
|
Assignee | |
Updated•3 months ago
|
|
|
Assignee | |
Updated•3 months ago
|
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/88da4811edd9 adjust how height is calculated in mail/test/browser/folder-display/browser_openingMessages.js. rs=bustage-fix DONTBUILD
|
|
Assignee | |
Comment 5•3 months ago
|
||
|
|
Assignee | |
Comment 6•3 months ago
|
||
Depends on D114596
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/bd43c68db6da convert mail/components/addrbook/content/addressbook.xhtml to top level <html>. r=henry https://hg.mozilla.org/comm-central/rev/d082e65a88d5 convert mail/components/preferences/preferences.xhtml to top level <html>. r=henry
|
||
Comment 8•3 months ago
|
||
|
|
||
Updated•3 months ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/50132988e778
Fix the Preference's font size after the HTML conversion. r=aleca
|
|
Assignee | |
Comment 10•2 months ago
|
||
|
||
Comment 11•2 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/ac7596a1da7b followup: move closing MOZ_OPENPGP to right position. r=henry
|
|
||
Comment 12•2 months ago
|
||
|
|
||
Updated•2 months ago
|
|
|
||
Comment 13•2 months ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/341d1f02efc5
Convert mail/components/downloads/content/aboutDownloads.xhtml to top level <html>. r=mkmelin DONTBUILD
|
||
Comment 14•1 month ago
|
||
Is it planned to include feed-subscriptions.xhtml in this party?
|
|
Assignee | |
Comment 15•1 month ago
|
||
My plan is to convert them all, but do it after 91 since there's not a huge rush and it can take time to weed out regressions, which have been subtle but annoying.
|
|
Assignee | |
Comment 16•1 month ago
|
||
@alta88 do you have a phabricator account? Did the conversion, but can't have you review without it.
|
|
||
Comment 17•1 month ago
|
||
I don't, the 2FA stuff was disinviting given no usage anymore.
|
|
Assignee | |
Comment 18•1 month ago
|
||
I noticed the layout of this dialog was rather messed up, so fixed it in the process.
|
|
||
Comment 19•1 month ago
|
||
It is still rather messed up, with some accumulated regressions along the way. Things that should be done here:
- Eliminate the platform specific css (one exception for osx only).
- The #selectFolder menu padding/margin has to be adjusted so the detail box doesn't jump when moving from folder to feed item in the tree.
- No need for #contentPane margin.
- Initial dialog (without persisted xulStore dimensions) is too small; tree is only 2 rows high.
- It would be better to use html elements (except tree and menu) and grid/flex model for the detail info box.
- themeableDialog doesn't seem to have the dark theme blue for checkbox/radio elements; it either should or maybe preferences.css can be included.
|
||
Comment 20•28 days ago
|
||
This change
https://hg.mozilla.org/comm-central/rev/d082e65a88d5#l1.103
breaks the ability to build with MOZ_UPDATER disabled. That will affect Linux distros. To fix this, we added
#ifdef MOZ_UPDATER
<script defer="defer" src="chrome://messenger/content/aboutDialog-appUpdater.js"></script>
+#else
+ <script defer="defer">
+ var { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");
+ var { XPCOMUtils } = ChromeUtils.import(
+ "resource://gre/modules/XPCOMUtils.jsm"
+ );
+ </script>
#endif
Essentially you get XPCOMUtils undefined later on. You may choose to do it some other way.
Description
•