Open Bug 1703164 Opened 1 year ago Updated 2 hours ago

convert top level <window> to <html> throughout the Thunderbird code base

Categories

(Thunderbird :: General, task)

Tracking

(thunderbird_esr78 wontfix)

ASSIGNED
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: mkmelin, Assigned: mkmelin)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Keywords: leave-open)

Attachments

(75 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Bug 1572062 converted the 3pane. For the most part styling has been adjusted already, and other preparations are now in place.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b31114f27664
convert mail/base/content/messageWindow.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/8f8fada0529c
convert mail/components/compose/content/messengercompose.xhtml to top level <html>. r=henry

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/88da4811edd9
adjust how height is calculated in mail/test/browser/folder-display/browser_openingMessages.js. rs=bustage-fix DONTBUILD
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/bd43c68db6da
convert mail/components/addrbook/content/addressbook.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/d082e65a88d5
convert mail/components/preferences/preferences.xhtml to top level <html>. r=henry

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/50132988e778
Fix the Preference's font size after the HTML conversion. r=aleca

Regressions: 1712535
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/ac7596a1da7b
followup: move closing MOZ_OPENPGP to right position. r=henry

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/341d1f02efc5
Convert mail/components/downloads/content/aboutDownloads.xhtml to top level <html>. r=mkmelin DONTBUILD

Is it planned to include feed-subscriptions.xhtml in this party?

My plan is to convert them all, but do it after 91 since there's not a huge rush and it can take time to weed out regressions, which have been subtle but annoying.

@alta88 do you have a phabricator account? Did the conversion, but can't have you review without it.

I don't, the 2FA stuff was disinviting given no usage anymore.

I noticed the layout of this dialog was rather messed up, so fixed it in the process.

It is still rather messed up, with some accumulated regressions along the way. Things that should be done here:

  1. Eliminate the platform specific css (one exception for osx only).
  2. The #selectFolder menu padding/margin has to be adjusted so the detail box doesn't jump when moving from folder to feed item in the tree.
  3. No need for #contentPane margin.
  4. Initial dialog (without persisted xulStore dimensions) is too small; tree is only 2 rows high.
  5. It would be better to use html elements (except tree and menu) and grid/flex model for the detail info box.
  6. themeableDialog doesn't seem to have the dark theme blue for checkbox/radio elements; it either should or maybe preferences.css can be included.

This change
https://hg.mozilla.org/comm-central/rev/d082e65a88d5#l1.103
breaks the ability to build with MOZ_UPDATER disabled. That will affect Linux distros. To fix this, we added

 #ifdef MOZ_UPDATER
   <script defer="defer" src="chrome://messenger/content/aboutDialog-appUpdater.js"></script>
+#else
+  <script defer="defer">
+    var { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");
+    var { XPCOMUtils } = ChromeUtils.import(
+      "resource://gre/modules/XPCOMUtils.jsm"
+    );
+  </script>
 #endif

Essentially you get XPCOMUtils undefined later on. You may choose to do it some other way.

Regressions: 1719336
No longer regressions: 1719336
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/fa72aeb98faa
convert mailnews/extensions/newsblog/feed-subscriptions.xhtml to top level <html>. r=henry
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/649372d0b492
follow-up - Fix a broken test. rs=bustage-fix
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a0a67cd423a5
convert mailnews/base/prefs/content/AccountManager.xhtml to top level <html>. r=Paenglab

Copies and Folders pane.

Depends on D124632

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/11d402e3146c
convert mail/components/im/content/addbuddy.xhtml to top level <html>. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/8319cb118621
convert mail/components/im/content/imAccounts.xhtml to top level <html>. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/b50b29fc54a7
convert mail/components/im/content/imAccountWizard.xhtml to top level <html>. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/b3944f15cc0f
convert mail/components/im/content/joinchat.xhtml to top level <html>. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/42f2868b0007
convert mailnews/base/prefs/content/am-main.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/597a9573fbcc
convert mailnews/base/prefs/content/am-server.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/9fc5dd5898a6
convert mailnews/base/prefs/content/am-serverwithnoidentities.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/eba60e1ccb89
convert mailnews/base/prefs/content/am-copies.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/46578897c7e9
convert mailnews/base/prefs/content/am-junk.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/9c4fbbbb8d05
convert mailnews/base/prefs/content/am-offline.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/0a04b6526c1e
convert mailnews/extensions/mdn/am-mdn.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/76e19f126207
convert mailnews/extensions/newsblog/am-newsblog.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/77b3a77849ea
convert mailnews/base/prefs/content/am-addressing.xhtml to top level <html>. r=henry

Convert to top level html, and remove <stringbundle>

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/3ff10ed0d3bd
convert ./mailnews/export/content/exportDialog.xhtml to top level <html>. r=henry

This is difficult to trigger. For testing you can just do

window.openDialog(
  "chrome://messenger-smime/content/certFetchingStatus.xhtml",
  "", "chrome,modal,resizable,centerscreen", null, null
);
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/46cffd1b9a85
convert mailnews/compose/content/sendProgress.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/0660a3e1ff9e
convert mailnews/import/content/importDialog.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/80542f807639
convert mailnews/import/content/fieldMapImport.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/d262b0cf9324
convert mailnews/extensions/smime/msgCompSecurityInfo.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/b0c1de752f55
convert mailnews/extensions/smime/certpicker.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/eace7e5c001f
convert mailnews/extensions/smime/certFetchingStatus.xhtml to top level <html>. r=henry

For testing, ucomment the last line in onload(), and run

window.openDialog("chrome://messenger/content/shutdownWindow.xhtml",
  "", "chrome,modal,resizable,centerscreen", null, null
);
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/690715e763df
convert mailnews/base/content/shutdownWindow.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/af327c38cbf2
convert mailnews/extensions/newsblog/feedAccountWizard.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/1be6b7b0185e
convert mailnews/base/content/newFolderDialog.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/88bebea13f70
convert mailnews/base/content/virtualFolderProperties.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/b87bf19809e3
convert mailnews/base/content/newmailalert.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e5b538bbb148
followup to changeset 88bebea13f70 (virtualFolderProperties.xhtml to top level html) due to test failures in comm/mail/test/browser/search-window/browser_searchWindow.js. rs=bustage-fix DONTBUILD
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4bbf35395a8d
convert mailnews/base/content/msgSelectOfflineFolders.xhtml to top level <html>. r=henry
Regressions: 1734577
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/774194f1c1a8
convert calendar/base/content/dialogs/calendar-invitations-dialog.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/78d2559050ab
convert mailnews/base/content/folderProps.xhtml to top level <html>. r=henry

I think the ealier work is tripping on <stringbundle> not being present (yet) in the dom.
There is still oddness of event handling with xul:dialog. The can't be where it should be (in head).

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9b58e351e107
virtualFolderProperties <stringbundle> removal. r=freaktechnik
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/6b719976f9e3
convert mailnews/base/content/msgSynchronize.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/c832cc4bd606
remove no longer needed body class="body" in messenger.xhtml. rs=me
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a849f74066e4
convert mailnews/base/content/virtualFolderListEdit.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/c7b2813a799f
convert mailnews/base/content/subscribe.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/42bfebd9c6d2
follow up to a849f74066e4 - fix linting. rs=eslint DONTBUILD
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/88f84ab6f94b
convert mailnews/base/content/markByDate.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/ec5da861d2b7
convert mailnews/base/content/renameFolderDialog.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/7b31c1cfcffb
convert mailnews/base/content/junkLog.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/8cbc6a589508
convert mailnews/base/prefs/content/am-card-dialog.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/867a4c689d51
convert mailnews/base/prefs/content/am-smtp.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/a9aa8a3b9077
convert mailnews/addrbook/prefs/content/pref-editdirectories.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/94a95510772d
convert mailnews/base/prefs/content/am-identities-list.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/62d67f138cfa
convert mailnews/base/prefs/content/removeAccount.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1ff7354b2466
follow-up to 867a4c689d51 - fix linting. rs=eslint DONTBUILD
Attachment #9260829 - Attachment description: Bug 1703164 - convert mailnews/addrbook/content/abCardDAVProperties.xhtml to top level <html>. r=henry → Bug 1703164 - convert mailnews/addrbook/content/abCardDAVProperties.xhtml to top level <html>. r=henry,Paenglab
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2dca250deaa7
convert mailnews/base/prefs/content/SmtpServerEdit.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/1a490ff809b7
convert mailnews/base/prefs/content/am-archiveoptions.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/fc2a3734c4ce
convert mailnews/base/prefs/content/am-identity-edit.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/bd0c98e22865
convert mailnews/base/prefs/content/am-server-advanced.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1869b1083658
convert mailnews/addrbook/content/abAddressBookNameDialog.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7f2555122329
convert mailnews/search/content/CustomHeaders.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/f3c39b8ae82f
convert mailnews/search/content/viewLog.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/197babe349e1
convert mailnews/search/content/FilterEditor.xhtml to top level <html>. r=henry

This is the dialog one gets by right clicking a contact "Add OTR Fingerprint" context menu.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1090401eeac3
convert chat/content/otr-add-fingerprint.xhtml to top level <html>. r=henry

This is the dialog one gets in chat for "Verify".

For testing use

var paramBlock = Cc["@mozilla.org/embedcomp/dialogparam;1"].createInstance(
  Ci.nsIDialogParamBlock
);
paramBlock.SetNumberStrings(3);
paramBlock.SetString(0, "An error was encountered preparing the calendar located at http://example.com for use. It will not be available.");
paramBlock.SetString(1, "0x12334");
paramBlock.SetString(2, "blablabla");
Services.ww.openWindow(
  null,
  "chrome://calendar/content/calendar-error-prompt.xhtml",
  "_blank",
  "chrome,dialog=yes,alwaysRaised=yes",
  paramBlock
);

For testing

window.openDialog(
  "chrome://calendar/content/calendar-conflicts-dialog.xhtml",
  "calendarConflictsDialog",
  "chrome,titlebar,modal",
  {
  item: { isEvent() { return true}, getProperty() { return "ABC"; }, get calendar() { return { name: "test"} }, title: "Test title" } ,
  mode: "modify",
  overwrite: false,
  }
);

For testing

window.openDialog(
  "chrome://calendar/content/calendar-conflicts-dialog.xhtml",
  "calendarConflictsDialog",
  "chrome,titlebar,modal",
  {
  item: { isEvent() { return true}, getProperty() { return "ABC"; }, get calendar() { return { name: "test"} }, title: "Test title" } ,
  mode: "modify",
  overwrite: false,
  }
);
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/85057d25d733
convert chat/content/otr-finger.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/93e4d449e781
convert chat/content/otr-auth.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/c87146f3e9a8
convert calendar/base/content/preferences/editCategory.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/b60a405286b9
convert calendar/base/content/dialogs/calendar-creation.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5f6ca8ed2cec
follow-up to c87146f3e9a80f9632d35578b67b5d48c6a4e4e6 - fix test. rs=me DONTBUILD
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5ee9579cf4e0
convert calendar/base/content/dialogs/calendar-conflicts-dialog.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2d2662f7a91f
convert calendar/base/content/dialogs/calendar-occurrence-prompt.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/49793e9acd94
convert calendar/base/content/dialogs/calendar-event-dialog-timezone.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8d19fb20b78a
convert calendar/base/content/dialogs/calendar-alarm-dialog.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/25e0821ebf6d
convert calendar/base/content/dialogs/calendar-error-prompt.xhtml to top level <html>. r=henry
Regressions: 1735048
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9042d4892485
convert calendar/base/content/item-editing/calendar-item-iframe.xhtml to top level <html>. r=henry
https://hg.mozilla.org/comm-central/rev/94a1c4858fd6
convert calendar/base/content/dialogs/calendar-summary-dialog.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0621b33d2f2a
convert calendar/base/content/dialogs/calendar-event-dialog-recurrence.xhtml to top level <html>. r=henry

Backed out the last patch for failures on Windows and possibly one on Mac as well.
https://hg.mozilla.org/comm-central/rev/d0c72993f2bb2a0d4dd2178cb4066340120e34a8

Regressions: 1762423
Regressions: 1746393
Regressions: 1764105
Regressions: 1763443
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8e7632bbfa1d
convert calendar/base/content/dialogs/publishDialog.xhtml to top level <html>. r=henry
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2643d2104b14
convert calendar/base/content/dialogs/calendar-properties-dialog.xhtml to top level <html>. r=henry

(In reply to Pulsebot from comment #96)

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/197babe349e1
convert mailnews/search/content/FilterEditor.xhtml to top level <html>.
r=henry

A little overzealous replacement here:
https://hg.mozilla.org/comm-central/rev/197babe349e1#l2.102
https://hg.mozilla.org/comm-central/rev/197babe349e1#l2.152

Regressions: 1773910
Regressions: 1774967
Regressions: 1777291
Regressions: 1777847
You need to log in before you can comment on or make changes to this bug.