Closed Bug 1732217 Opened 4 years ago Closed 4 years ago

./mach busted file seems to be busted

Categories

(Firefox Build System :: Mach Core, defect)

Product:
Firefox Build System
Component:
Mach Core
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox-esr91 unaffected, firefox92 unaffected, firefox93 unaffected, firefox94 fixed)

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox92 --- unaffected
firefox93 --- unaffected
firefox94 --- fixed

People

(Reporter: nika, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

I attempted to use ./mach busted file ide to file bug 1732216, however it failed with an error:

AttributeError: '_MachCommand' object has no attribute 'cls'

  File "/home/nika/src/moz/central/tools/mach_commands.py", line 97, in busted_file
    method = getattr(handler.cls, handler.method)

The relevant line is https://searchfox.org/mozilla-central/rev/1749ba14c2ebe200855802c478780122135727f2/tools/mach_commands.py#97.

I expect that, like bug 1732216, this error may be caused by the change to run mach commands as standalone functions in bug 1696251, though I don't know for sure.

The bug causing this regression was backed out, and the flaw in the regressing patch has been resolved.
Thanks for the report!

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Set release status flags based on info from the regressing bug 1696251

status-firefox92: --- → unaffected
status-firefox93: --- → unaffected
status-firefox94: --- → affected
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → unaffected
status-firefox94: affected → fixed
Target Milestone: --- → 94 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.