Closed Bug 1732600 Opened 2 months ago Closed 2 months ago

pass down "transform to ancestor scale" to child processes and use it displayport/apz related places

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

RESOLVED FIXED
95 Branch
Fission Milestone Future
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(6 files)

No description provided.

This is the conclusion we came to after some discussion.

Assignee: nobody → tnikkel
Status: NEW → ASSIGNED

In bug 1731929 we added this value, here we give it the value we want for child processes. I think the code comments should explain it.

Depends on D126628

Depends on: 1731929
Blocks: 1732660
Summary: pass down "transform to ancestor scale" to child processes → pass down "transform to ancestor scale" to child processes and use it
Summary: pass down "transform to ancestor scale" to child processes and use it → pass down "transform to ancestor scale" to child processes and use it displayport/apz related places

This else should only get hit if we can't get the docshell or content viewer from the prescontext, which should only be unusual setting up or tearing down timeframes, so it doesn't matter too much.

Fission Milestone: --- → Future

It is unused, it accidentally slipped in in bug 1731929 but was never used.

Depends on D126628

Attachment #9243014 - Attachment description: Bug 1732600. Use ancestor process tranform to ancestor scale in nsLayoutUtils::CalculateBoundingCompositionSize. r?botond → Bug 1732600. Use ancestor process transform to ancestor scale in nsLayoutUtils::CalculateBoundingCompositionSize. r?botond
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/832e46a88922
Update a comment on FrameMetrics::mCumulativeResolution. r=botond
https://hg.mozilla.org/integration/autoland/rev/fcba9b334513
Remove PixelCastJustification::TransformToAncestorScaleIsStoredUntyped. r=botond
https://hg.mozilla.org/integration/autoland/rev/ea1f49e03b8b
Pass down transform to ancestor scale to child processes. r=botond
https://hg.mozilla.org/integration/autoland/rev/d39165de0a11
Use ancestor process transform to ancestor scale in nsLayoutUtils::CalculateBoundingCompositionSize. r=botond
https://hg.mozilla.org/integration/autoland/rev/e3712c7214b8
Make ComputeDisplayportScale use the ancestor process transform to ancestor scale. r=botond
https://hg.mozilla.org/integration/autoland/rev/9e95cc6419d7
Make GetDisplayPortFromMarginsData use ancestor process transform to ancestor scale. r=botond

Timothy, does this bug affect both Fission and e10s users? Should your fix be uplifted to Beta 94 (for the Fission MVP release in Firefox 94)?

Flags: needinfo?(tnikkel)

Similar to bug 1732660, comment 6. These patches were ready right on the soft freeze deadline and I opted to wait to land them, so I don't think we need to uplift them.

Flags: needinfo?(tnikkel)

(In reply to Timothy Nikkel (:tnikkel) from comment #10)

Similar to bug 1732660, comment 6. These patches were ready right on the soft freeze deadline and I opted to wait to land them, so I don't think we need to uplift them.

SGTM. In that case, I will set status-firefox94=wontfix.

You need to log in before you can comment on or make changes to this bug.