Closed Bug 1732884 Opened 4 months ago Closed 4 months ago

Fix highlight/hover state of click-to-open items (with the improvements-to-downloads pref turned on)

Categories

(Firefox :: Downloads Panel, defect, P3)

Desktop
All
defect
Points:
1

Tracking

()

VERIFIED FIXED
95 Branch
Tracking Status
firefox94 --- verified
firefox95 --- verified

People

(Reporter: Gijs, Assigned: bigiri)

References

Details

(Whiteboard: [fidefe-mr11-downloads])

Attachments

(1 file)

When I changed the hover state in bug 1715001 I accidentally neglected to change it for the click-to-open-while-still-downloading state (which we're not shipping yet; it's behind the browser.download.improvements_to_download_panel pref). It should visually match the hover states for completed downloads.

S3 because this isn't severe enough to be S1/S2.

Severity: -- → S3
Points: --- → 1
Priority: -- → P3
Whiteboard: [fidefe-mr11-downloads]
See Also: → 1732893
Assignee: nobody → bigiri
Status: NEW → ASSIGNED
Blocks: 1733587
No longer blocks: 1732347

Updated the hover appearance of currently downloading items, to mimic that of items that are already downloaded, when the improvements-to-downloads pref is turned on.

Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a0c6ce2e379
Update download panel appearance when improvements are turned on r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Blocks: 1734397

The patch landed in nightly and beta is affected.
:bigiri, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(bigiri)

Comment on attachment 9244041 [details]
Bug 1732884 - Update download panel appearance when improvements are turned on r=Gijs

Beta/Release Uplift Approval Request

  • User impact if declined: Download mouse over highlights with download improvements turned on will render correctly in Firefox Beta.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Set the browser.download.improvements_to_download_panel preference to true and attempt to download a file. The 10GB file on https://testfiledownload.com/ worked well for me. As the file download mouse over the the progress bar and verify that the highlight extends across the full width of the download row within the padding and margins. Then mouse over the cancel button and verify that highlights separately.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Cosmetic CSS changes.
  • String changes made/needed:
Flags: needinfo?(bigiri)
Attachment #9244041 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9244041 [details]
Bug 1732884 - Update download panel appearance when improvements are turned on r=Gijs

Approved for 94.0b5.

Attachment #9244041 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified that using latest Nightly and latest Beta build across platforms (Windows 10, macOS 11.6 and Ubuntu 18.04) the highlight extends across the full width of the download row within the padding and margins.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.