Closed Bug 173311 Opened 22 years ago Closed 22 years ago

[Macho] RealPlayer One 9.0b2 causes crash at start-up [@ js_AtomizeString]

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.3beta

People

(Reporter: nacohen, Assigned: ccarlen)

References

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

Crash log from Chimera crash associated with RealPlayer One
2.80 KB, text/plain
Details
patch
9.76 KB, patch
ccarlen
: review+
sfraser_bugs
: superreview+
dbaron
: approval+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021007 Chimera/0.5+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021007 Chimera/0.5+

I installed the new RealPlayer One 9.0b2 beta today. Navigator 0.5 plus latest
nightly builds) began crashing at start-up. IE, Omniweb still ran fine. After
trying many other things (reinstall, preference deletion, privilege repair,
etc.) I removed the two aliases that realplayer had in my Internet Plug-in
folder. Navigator once again began launching without problem.

Reproducible: Always

Steps to Reproduce:
1.Install Real Player 9.0b2 beta.
2.Launch Navigator
3.

Actual Results:  
Crash on start-up

Expected Results:  
Chimera should have launched.

See crash log.
*** Bug 173215 has been marked as a duplicate of this bug. ***
Confirming issue.
Status: UNCONFIRMED → NEW
Ever confirmed: true
If I just remove the RealPlayer Plugin.xpt file from /Library/Internet Plug-Ins,
the application launchs for me.
I can reproduce this issue with a second mac running Chimera (2002-10-07-04)
after installing RP B2. Removing the RealPlayer Plugin.xpt alias allows Chimera
to launch succeusfully. Tested under 10.2.
Well apparently the xpt file activates the nsScriptSecurityManager which is
causing the problem.

This, unfortunately, does not crash on my machine.
*** Bug 173424 has been marked as a duplicate of this bug. ***
I had the same crash , but only with one specific user account. I have
personnaly two account on my system, when I use the one with wich I install and
launch realplayer for the last time, no problem with Navigator. 

If logout and log-on with my second account , navigator crash at startup. Could
this be related to credentials and read/write permissions of the realplayer plugin.
*** Bug 173454 has been marked as a duplicate of this bug. ***
*** Bug 173460 has been marked as a duplicate of this bug. ***
*** Bug 173455 has been marked as a duplicate of this bug. ***
Target Milestone: --- → Chimera0.6
I think this crash may only happen with optimized builds, and then only if you
delete xpti.dat in the components directory.
>delete xpti.dat in the components directory.

Hmm, ok, I'll try that... I've installed Real Player 3 times, moved it around,
done tried nightly bits and debug bit... so far it has worked for me every time.
Ok, I see the xptiInterfaceInfoManager throwing some errors. It looks like it's
failing to read the file because its stated file size doesn't agree with it's
actual file size.
*** Bug 173643 has been marked as a duplicate of this bug. ***
*** Bug 173656 has been marked as a duplicate of this bug. ***
A stupid question? shouldn't there be some code in the plugin handlers that
saves chimera from crashing when plugins do or are weird things?
*** Bug 173660 has been marked as a duplicate of this bug. ***
*** Bug 173710 has been marked as a duplicate of this bug. ***
Here's the deal. What's actually happening is that the RealPlayer Plugin.xpt
alias is causing NS_InitEmbedding to fail, and we crash later dereffing a NULL
JSContext.

The real problem here is how we deal with autoregistering things that are
aliases. Right now, we have some differences between debug and opt behaviour (in
nsLocalFile::GetParent) which explain why this is opt only.
Conrad has the fix for this.
Assignee: bnesse → ccarlen
Attached patch patch — — Splinter Review 
Patch does a few things:
(1) Fixes xptiInterfaceInfoManager so that it sets the state of the followLinks
attribute on the files it uses. Here's the problem: xptiInterfaceInfoManager
scans some directory and finds an .xpt file (/foo/file.xpt). In this case,
file.xpt is an alias and the file that xpti is using has followLinks == TRUE.
Later, xpti calls GetParent() on file.xpt and, since file.xpt is an alias and
the actual file is elsewhere, the parent is not /foo. This causes
xptiInterfaceInfoManager to freak. The fix is to turn off followLinks when
scanning directories - just return the files that are actual children of the
enumerated dirs, not the resolved alias files. Then, when actually reading the
file, set followLinks to true because we want to read the actual file, not the
alias.
(2) Removes the DEBUG code in GetParent() which was originally put in to work
around the above problem.
(3) OpenNSPRFileDesc and OpenANSIFileDesc were not observing the state of
followLinks.

need r=.
BTW, since more of our code should probably pay attention to the followLinks
state, setting it to some state, using the file, and then restoring it, this
little object:
http://lxr.mozilla.org/seamonkey/source/xpcom/io/nsLocalFileOSX.cpp#86
should be made public. It makes restoration of the previous state automatic. Of
course, it would have to take an nsILocalFile* instead of an nsLocalFile&.

Doug, what do you think of this little util? (As in where it could live)
Comment on attachment 102579 [details] [diff] [review]
patch

I like having one version of GetParent a whole lot better. r=bnesse.
*** Bug 173895 has been marked as a duplicate of this bug. ***
*** Bug 173922 has been marked as a duplicate of this bug. ***
Revising summary.
Keywords: crash
Summary: RealPlayer One 9.0b2 causes crash at startup → RealPlayer One 9.0b2 crashes Chimera at start-up [@ js_AtomizeString]
Checked into Chimera branch. Still needs an sr= for trunk since Mach-0 mozilla
will have the same problem.
conrad, I do not think that this is critical to a Gecko API.  Feel free to file
a bug.  I will probably future it unless you have patches for this.  This code
would exist in the xpcom/glue, of course.
*** Bug 173974 has been marked as a duplicate of this bug. ***
*** Bug 173955 has been marked as a duplicate of this bug. ***
*** Bug 174068 has been marked as a duplicate of this bug. ***
*** Bug 174051 has been marked as a duplicate of this bug. ***
*** Bug 174064 has been marked as a duplicate of this bug. ***
*** Bug 174015 has been marked as a duplicate of this bug. ***
*** Bug 174169 has been marked as a duplicate of this bug. ***
Should this be resolved per comment 28?
Whoops, this isn't fixed. Chimera/2002101104 still crashes on start-up at js_AtomizeString.
*** Bug 174309 has been marked as a duplicate of this bug. ***
> Whoops, this isn't fixed. Chimera/2002101104 still crashes on start-up at
js_AtomizeString.

Notice that at 2002101104 the fix was not checked in.


Yep, this problem isn't occuring with the 2002-10-12-04 build running under 10.2.1.
Whiteboard: [fixed in chimera]
Keywords: realplayer
Moving to browser, since that's where we need a fix now.
Component: Plug-ins → XPCOM
Product: Chimera → Browser
Target Milestone: Chimera0.6 → ---
Version: unspecified → other
> Moving to browser, since that's where we need a fix now.

Arg. Just downloaded a Mach-0 nightly and was painfully reminded of that. This
patch needs sr= as the first step in getting on the trunk.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.3beta
Comment on attachment 102579 [details] [diff] [review]
patch

sr=sfraser
Attachment #102579 - Flags: superreview+
I am seeing similar symptoms (same backtrace as the one attached and crashing on 
startup.) but, while I have the RealOne 9.0b2 player installed, this only started to happen 
once I tried one of the nightly builds (20021017*, I believe) and then backed down to 0.5 
release after having a few crashes long after the browser started up. (The nightly build 
was consistenly crashing on the NY Times web page starting yesterday evening.) Now 
0.5 release is crashing upon startup even after removing /Library/Mozilla, ~/Library/
Application Support/Chimera, ~/Library/Mozilla, and ~/.mozilla and restarting. (There was 
a zombie process of Chimera sitting around.)

If this should be filed as a seperate bug, please let me know.
No, same bug. Only open a new bug if a recent nightly still crashes.
Summary: RealPlayer One 9.0b2 crashes Chimera at start-up [@ js_AtomizeString] → [Macho] RealPlayer One 9.0b2 causes crash at start-up [@ js_AtomizeString]
Comment on attachment 102579 [details] [diff] [review]
patch

putting bnesse's r= here. I'll see if I can get this into 1.2 but it does touch
some common, XP code.
Attachment #102579 - Flags: review+
Blocks: 176301
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in chimera]
Verified on the 2002-11-04-07 trunk build under 10.1.5.
Status: RESOLVED → VERIFIED
Crash Signature: [@ js_AtomizeString]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: