1733660 - focused find bar outline is clipped on the left side

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[Sören Hentzschel]

Attachment: screenshot

The outline of the focused find bar is clipped on the left side. This is a regression from bug 1728368 in Firefox 92.0.1 - Firefox 92.0 was not affected. Firefox Nightly is still affected. The issue could be reproduced in the Firefox support by users with Windows 10, Windows 7 and macOS (other platforms were not tested).

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1733660 - Keep finbar textbox focus ring within the textbox bounds so it doesn't overflow the findbar container. r=Itiel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41e0785cdd18
Keep finbar textbox focus ring within the textbox bounds so it doesn't overflow the findbar container. r=Itiel

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/41e0785cdd18

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate for Beta & ESR91 approval when you get a chance.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9244199 [details]
Bug 1733660 - Keep finbar textbox focus ring within the textbox bounds so it doesn't overflow the findbar container. r=Itiel

Beta/Release Uplift Approval Request

• User impact if declined: cosmetic issue
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix
• String changes made/needed:

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9244199 [details]
Bug 1733660 - Keep finbar textbox focus ring within the textbox bounds so it doesn't overflow the findbar container. r=Itiel

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: recent regression on ESR
• User impact if declined: cosmetic issue
• Fix Landed on Version: 95 (94 pending)
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix
• String or UUID changes made by this patch:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244199 [details]
Bug 1733660 - Keep finbar textbox focus ring within the textbox bounds so it doesn't overflow the findbar container. r=Itiel

Approved for 94.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/741dbad616b4

Comment 9

[Ciprian Georgiu, Desktop QA]

Reproduced this bug using the info from comment 0, on Win 11 x64 with an affected Nightly build.

The issue is verified as fixed on the latest builds: Nightly 95.0a1, Beta 94.0b4. Tested across platforms, Win 11 x64, macOS 11 and Ubuntu 18.04 x64.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244199 [details]
Bug 1733660 - Keep finbar textbox focus ring within the textbox bounds so it doesn't overflow the findbar container. r=Itiel

Approved for 91.3esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/d3d4309e8f95

Comment 13

[Sören Hentzschel]

This is only partially fixed. The regular outline looks good now but once you enter something that cannot be found on the website there is a red outline - and that outline is still clipped (tested in Firefox Nightly).

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:harry, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 15

[Sören Hentzschel]

Dao, please see comment #13. I needinfo?ed you to make you aware since the Firefox 94 RC builds will be built soon and it's already regressed since Firefox 92.0.1.

Comment 16

[Chris Peterson [:cpeterson]]

Beta 94 and Nightly 95 are still affected.

Comment 17

[Dão Gottwald [:dao]]

(In reply to Sören Hentzschel from comment #13)

This is only partially fixed. The regular outline looks good now but once you enter something that cannot be found on the website there is a red outline - and that outline is still clipped (tested in Firefox Nightly).

This bug was filed on the focus outline, the patch has landed and is working as intended. Please file a new one on the red outline so we can track that properly.

Comment 18

[Chris Peterson [:cpeterson]]

(In reply to Dão Gottwald [::dao] from comment #17)

(In reply to Sören Hentzschel from comment #13)

This is only partially fixed. The regular outline looks good now but once you enter something that cannot be found on the website there is a red outline - and that outline is still clipped (tested in Firefox Nightly).

This bug was filed on the focus outline, the patch has landed and is working as intended. Please file a new one on the red outline so we can track that properly.

I filed new bug 1737389 for the clipped red outline.

Comment 19

[Ciprian Georgiu, Desktop QA]

This is also verified as fixed on 91.3.0esr (2021-10-28).