1745455 - Findbar close button is still overflowing

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[aoia7rz7l]

This was supposedly fixed in bug 1724194 but I can still reproduce on 91.4.0esr and 96.0b3.

STR:

1. Set privacy.resistfingerprinting to true, restart Firefox, and leave the window non-maximized.
2. Visit bug 1724194.
3. Press Ctrl + F and search for mozilla.
4. Cycle through matches until the text Reached end of page, continued from top or Reached top of page, continued from bottom appears.

Expected Behavior:

Nothing overflows and I can still close the find bar using the close button (see ESR78).

Actual Behavior:

Text Reached end of page, continued from top or Reached top of page, continued from bottom overflows, hiding the findbar close button.

Comment 1

[Patrick (he/him)]

Able to reproduce in Firefox 95 and Nightly 97.0a1 (2021-12-14).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:harry, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Harry Twyford]

Afaict, replacing overflow: hidden with overflow-inline: clip in bug 1733660 broke this.

Comment 4

[Harry Twyford]

Attachment: Bug 1745455 - Partially revert bug 1733660 to ensure close button is displayed. r?dao!

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733660

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c945b3fc90f
Partially revert bug 1733660 to ensure close button is displayed. r=dao

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3c945b3fc90f

Comment 9

[Giorgia Nichita, Release Desktop QA]

I was able to reproduce this issue on Firefox 96.0 on both Windows 10 and Ubuntu 20.04 following the STR from Comment 0.
Verified fixed on 97.0b1 (20220110145841) on the above platforms.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9257062 [details]
Bug 1745455 - Partially revert bug 1733660 to ensure close button is displayed. r?dao!

Simple CSS fix for an issue picking up multiple reports. Verified by QA and no known regressions in the wild. Approved for 91.6esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/e599b5e0957e

Comment 12

[Giorgia Nichita, Release Desktop QA]

This issue was verified as fixed on Firefox 91.6.0 esr (20220131231250) on both Windows 10 x64 and Ubuntu 21.04.