1734264 - Upgrade spotlight visual adjustments from design feedback

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

https://www.figma.com/file/blhdnzQOhWYKcdiCzywMuG/MR2-Onboarding?node-id=2076%3A116138

Except for the white focus ring on variant selection. Maintaining existing 50% transparent black behavior now that disc gradients are updated. Also not doing the color circle focus ring removal.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1734264 - Upgrade spotlight visual adjustments from design feedback r=pdahiya

Fix background sizing of horizontal color circles. Remove duplicate focus indicator on color circles. Position primary button with invisible secondary button. Update noodle svg to avoid aliasing. Adjust spacing among and around color circles. Adjust variant disc and color circles gradient colors and direction (vertical) now always with black variant text.

Comment 2

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Additional polish of MR2 upgrade spotlight dialog

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccad9fa1b032
Upgrade spotlight visual adjustments from design feedback r=pdahiya

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ccad9fa1b032

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this ready for a Beta uplift request?

Comment 6

[Ed Lee :Mardak]

This hasn't been verified yet, and the patch here happens to depend/conflict with bug 1734187, which has a regression being fixed in bug 1733690 -- those two probably want to be uplifted together. Or we can first uplift the patches that have made it to nightly already?

Comment 7

[Ed Lee :Mardak]

Comment on attachment 9244444 [details]
Bug 1734264 - Upgrade spotlight visual adjustments from design feedback r=pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: Visual designs are not as polished, e.g., positioning, sizing, background images, colors/gradients, font sizes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open upgrade spotlight

2. Go through all 3 screens

• List of other uplifts needed: Bug 1734187
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mostly css and image adjustments. Depends on patch from bug 1734187. This patch was updated for beta uplift to avoid also uplifting bug 1734136, which changes the same image files.
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9244444 [details]
Bug 1734264 - Upgrade spotlight visual adjustments from design feedback r=pdahiya

Approved for 94.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d47b8f43f0cf

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

Marking this issue as Verified based on the work done for the feature. For more information see QA-1202.