Closed Bug 1734585 Opened 3 years ago Closed 3 years ago

Variation button text (e.g., Bold, Dark) from upgrade spotlight are not visible with High Contrast Mode

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
95 Branch
Iteration:
95.1 - Oct 4 - Oct 17
Tracking Flags:
Tracking Status
firefox93 --- unaffected
firefox94 --- verified
firefox95 --- verified

People

(Reporter: srosu, Assigned: Mardak)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

HCM_Windows.png
18.23 KB, image/png
Details
Attached image HCM_Windows.png —

[Affected versions]:

  • Firefox Nightly 95.0a1 (Build ID: 20211006213819)
  • Firefox Beta 94.0b2 (Build ID: 20211005185813)

[Affected Platforms]:

  • Windows 10 x64

[Prerequisites]:

  • Have a Firefox Nightly/Beta browser that has been upgraded to the latest version.
  • Have the “Upgrade” spotlight displayed.
  • Have the High Contrast Mode enabled.

[Steps to reproduce]:

  1. Click the “Explore colorways" button.
  2. Select each theme from the carousel and observe the "Bold" and "Balanced" buttons.

[Expected result]:

  • The text of the “Balanced” and “Bold” buttons are visible for all the themes displayed in the carousel.

[Actual result]:

  • The text of the “Balanced” and “Bold” buttons are not visible when the Default, Cheers, and Foto themes are selected.

[Notes]:

  • This issue is not reproducible when the “Balanced” and “Bold” buttons are focused.
  • Attached is a screenshot of the issue.

@Ed, @Harry, can you please weigh in on this?

Flags: needinfo?(htwyford)
Flags: needinfo?(edilee)

Directing this to Ed.

Flags: needinfo?(htwyford)

Yeah this only affects certain themes right now, but bug 1734264 will be changing the text color (and backgrounds) which should also fix this bug.

Assignee: nobody → edilee
Iteration: --- → 95.1 - Oct 4 - Oct 17
Depends on: 1734264
Flags: needinfo?(edilee)
Priority: -- → P1
See Also: → 1734187

Fixed with bug 1734264 https://hg.mozilla.org/mozilla-central/rev/ccad9fa1b032

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
OS: Windows → All
Summary: [Upgrade Users][Windows] The text of the “Balanced” and “Bold” buttons from the Onboarding dialog are not visible when the High Contrast Mode is enabled → Variation button text (e.g., Bold, Dark) from upgrade spotlight are not visible with High Contrast Mode

I have verified this issue using the latest Firefox Nightly 95.0a1 (Build ID: 20211008094833) on Windows 10 x64.

  • The text of the “Balanced” and “Bold” buttons are visible for all the themes displayed in the carousel when the High Contrast Mode is enabled.
Status: RESOLVED → VERIFIED
status-firefox95: fixed → verified
  • The text of the “Balanced” and “Bold” buttons is visible for all the themes displayed in the upgrade spotlight with High Contrast Mode.
status-firefox94: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: