1734394 - Make GeckoView use the native session store collector

Status: RESOLVED FIXED

(GeckoView :: Sandboxing, task, P1)

Description

[Andreas Farre [:farre]]

The tricky part of getting GeckoView to use the native collector is how to handle incremental updates of scroll position and formdata coming from any part of the browsing context tree and any content child process.

The best would probably to move the ownership of the objects referenced by TabStateCache._data.get(permanentKey).formdata and TabStateCache._data.get(permanentKey).scroll to platform, along with TabStateCache.updatePartialWindowStateChange. That way, TabStateCache.update could go back to just receiving an object to store in TabStateCache._data.get(permanentKey).formdata when formdata gets updated, and correspondingly for scroll. Since that object should have a reference from within platform, the call to TabStateCache.update would possibly not be needed, but we might still have to keep it around due to how we restore.

In the case of restore, we would probably see a flow where the object pointed to by TabStateCache._data.get(permanentKey).formdata begins by not having a reference from platform, but when the restore completes we'd collect the data in platform and then write out the new object.

Comment 1

[Andreas Farre [:farre]]

Attachment: WIP: Bug 1734394 - Part 1: Add ToString to SessionStore{Form, Scroll}Data. r=peterv!

Comment 2

[Andreas Farre [:farre]]

Attachment: WIP: Bug 1734394 - Part 1: Turn SessionStoreUtils::NATIVE_LISTENER into a pref. r=peterv!

Depends on D131155

Comment 3

[Andreas Farre [:farre]]

Attachment: WIP: Bug 1734394 - Part 2: WIP

Depends on D131156

Comment 4

[Chris Peterson [:cpeterson]]

Unassigning farre since this bug requires GeckoView work. The GeckoView team will look this bug in 101.

Comment 5

[Chris Peterson [:cpeterson]]

Tracking for 102. Blocked waiting for farre to fix bug 1739450 in 101.

Comment 6

[Chris Peterson [:cpeterson]]

Knowledge dump from Kashav about session restore on desktop:

https://docs.google.com/document/d/13OsWKzLXqGgcYTcsY9qw7fCMeGdyxejtonpRi_l_PyM/edit

Comment 7

[Chris Peterson [:cpeterson]]

Agi would like to work on this in 102.

Comment 8

[Cathy Lu [:calu]]

Attachment: Bug 1734394 - Make Geckoview use the session store collector

When the session storage prefs are enabled, GeckoSession updateSessionState will provide the bundle of information, including zoom, scroll, and form data, to the delegate. Currently works for Fission and on Fenix.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39559c43173a
Make Geckoview use the session store collector r=geckoview-reviewers,agi,farre

Comment 10

[Marian-Vasile Laza]

Backed out changeset 39559c43173a (Bug 1734394) for causing bustages on GeckoBundleUtils.cpp.
Backout link
Push with failures
Failure Log
Also bc4 Failure Log

Comment 11

[Narcis Beleuzu [:NarcisB]]

Please also check this bc failure

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56a33c1c3210
Make Geckoview use the session store collector r=geckoview-reviewers,agi,farre

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out changeset 56a33c1c3210 (Bug 1734394) for causing build bustages in GeckoBundleUtils.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=cVfNGWgiSjGblVpyArsuKQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=56a33c1c32104ca5121279306c265a208720ab02

Log: https://treeherder.mozilla.org/logviewer?job_id=382463778&repo=autoland&lineNumber=38235

Backout: https://hg.mozilla.org/integration/autoland/rev/7c4f1e3d814342a8f5aa52258a349e4289469183

Comment 14

[Chris Peterson [:cpeterson]]

Moving Android Fission bugs to the new GeckoView::Sandboxing component.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67fae8447273
Make Geckoview use the session store collector r=geckoview-reviewers,agi,farre,peterv

Comment 16

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing Assertion failures on StaticPrefList_browser.h. CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line :
Assertion failure: staticPrefValue == preferenceValue (Preference 'browser.sessionstore.platform_collection' got modified since StaticPrefs::browser_sessionstore_platform_collection_AtStartup was initialized. Consider using an always mirror kind instead), at /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPrefList_browser.h:504

Comment 17

[Cathy Lu [:calu]]

Attachment: Bug 1734394 - Make Geckoview use the session store collector

When the session storage prefs are enabled, GeckoSession updateSessionState will provide the bundle of information, including zoom, scroll, and form data, to the delegate. Currently works for Fission and on Fenix.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/519c8a9a5f8c
Make Geckoview use the session store collector r=geckoview-reviewers,agi,farre,peterv

Comment 19

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/519c8a9a5f8c

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.