Restore Tab History for Fission
Categories
(GeckoView Graveyard :: Sandboxing, enhancement, P1)
Tracking
(firefox100 wontfix, firefox101 wontfix, firefox102 wontfix, firefox103 wontfix, firefox104 wontfix, firefox105 fixed)
People
(Reporter: agi, Assigned: calu)
References
(Blocks 2 open bugs, Regressed 1 open bug)
Details
(Whiteboard: [fission:android:m2] [geckoview:m103] [geckoview:m104] [geckoview:m105])
Attachments
(1 file)
As part of the Fission work we need to migrate all our framescripts to Actors. This tracks the work needed to move SessionStateAggregator.js to a child actor.
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
Looks like platform is making this easier for us so let's wait for that.
Reporter | ||
Comment 2•4 years ago
|
||
This also includes enabling the following tests on Fission:
HistoryDelegateTest#onHistoryStateChangeSavingState
ProgressDelegateTest#saveAndRestoreStateNewSession
ProgressDelegateTest#saveAndRestoreState
ProgressDelegateTest#flushSessionState
ProgressDelegateTest#noHistoryDelegateOnSessionStateChange
NavigationDelegateTest#purgeHistory
Reporter | ||
Comment 3•4 years ago
•
|
||
New test that relies on SessionStateStorage
:
WebExtensionTest#testRestoringExtensionPagePreservesMessages
from Bug 1675644.
Reporter | ||
Comment 4•4 years ago
|
||
Discussed in the Fission-Android meeting, sounds like it might take a while for the desktop code to migrate so maybe we want to have a stop-gap migration first.
Comment 5•4 years ago
|
||
Tracking this bug for Android Fission milestone M2 (pass tests with Fission enabled)
Reporter | ||
Comment 6•3 years ago
|
||
Email from Andreas Farre [:farre]:
I've been digging around a bit in SessionStateAggregator.js to see
what's needed to move it to the parent process in preparation for
Fission. Have you a plan in mind for how you want to do this?With the work we've already done it feels like collection should be
fairly easy to port to GeckoView, using code from TabStateCache.jsm[1]
to handle incremental updates from different content children (or
really different WindowGlobalChild) as some kind of intermediary step
before doing SessionState.updateSessionState. Or something similar.For the restore step I'll have to bring in Kashav for input, since
he's the more knowledgeable. My rough overview seems to indicate that
restore might be harder. This is also more dependant on Session
History in the parent process, I guess.In the end we want to have a system that is on, even if Fission isn't.
This is a bit cursory, but I thought that it would at least help us get started!
Updated•3 years ago
|
Updated•3 years ago
|
Comment 7•3 years ago
|
||
Agi, what's the expected timescale for this bug? This blocks bug 1758481 which we would like to complete in the 103 cycle (not before to avoid breaking some things just before ESR), would you be able to do this in that timeframe?
Reporter | ||
Comment 8•3 years ago
|
||
Hi Mark, Sorry I didn't realize this was time sensitive, we probably will get this done by 103 but I don't see any reason to delay the other patch in the meanwhile. I approved https://phabricator.services.mozilla.com/D142757
Updated•2 years ago
|
Reporter | ||
Comment 10•2 years ago
|
||
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Cathy will pick up Agi's WIP after she lands bug 1734394.
Assignee | ||
Updated•2 years ago
|
Comment 12•2 years ago
|
||
Moving Android Fission bugs to the new GeckoView::Sandboxing component.
Updated•2 years ago
|
Comment 13•2 years ago
|
||
105
Updated•2 years ago
|
Comment 14•2 years ago
|
||
Comment 15•2 years ago
|
||
bugherder |
Updated•6 months ago
|
Description
•