1734932 - Unify Intl APIs in intl/unicharutil/util/ICUUtils.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Dan Minor [:dminor]]

Work: Small
What it is: Various calls to unicode number APIs

https://searchfox.org/mozilla-central/source/intl/unicharutil/util/ICUUtils.cpp

Comment 1

[Dan Minor [:dminor]]

This will be easier to clean up after Bug 1719548, since some of this code is also used in nsIDNService.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1734932 - Remove unused BCP47CodeToLocale implementation; r=#platform-i18n-reviewers!

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1734932 - Use intl::NumberFormat for LocalizeNumber; r=#platform-i18n-reviewers!

Depends on D133122

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1734932 - Add intl::NumberParser; r=#platform-i18n-reviewers!

Awkwardly, this relies upon a different ICU4C NumberFormat API than
the existing intl::NumberFormat implementation, so it seems best to
have this live in a separate class.

Depends on D133123

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1734932 - Use NumberParser for ParseNumber; r=#platform-i18n-reviewers!

Depends on D133124

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a59c501510ea
Remove unused BCP47CodeToLocale implementation; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/c39b3b3cb36e
Use intl::NumberFormat for LocalizeNumber; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/ddaf501f90bc
Add intl::NumberParser; r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/eea99ed6a494
Use NumberParser for ParseNumber; r=platform-i18n-reviewers,gregtatum

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a59c501510ea
https://hg.mozilla.org/mozilla-central/rev/c39b3b3cb36e
https://hg.mozilla.org/mozilla-central/rev/ddaf501f90bc
https://hg.mozilla.org/mozilla-central/rev/eea99ed6a494