1719548 - Unify Intl APIs in netwerk/dns/nsIDNService.h/cpp

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

Work: Medium
What it is: uscript_getScriptExtensions, various calls to uidna

https://searchfox.org/mozilla-central/source/netwerk/dns/nsIDNService.h
https://searchfox.org/mozilla-central/source/netwerk/dns/nsIDNService.cpp

Comment 1

[Dan Minor [:dminor]]

Greg or I will work on this one.

Comment 2

[Greg Tatum [:gregtatum]]

uscript_getScriptExtensions is happening in https://phabricator.services.mozilla.com/D130977 but that still leaves uidna to be unified.

Comment 3

[Greg Tatum [:gregtatum]]

Hey Yoshi, we just finished a unified Intl triage session. We're trying to divide out the remaining work and ensure every bug in scope has an owner. Would you be interested and available to take on this bug before H2 is over? This bug is marked as a "medium" but, it's in a file you are already working on so we thought you might be interested. If you don't have time for what's left in H2 we will find someone else on the team to work on it.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Yes, I could finish this soon.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719548 - Part 1: Add a mozilla::intl::IDNA class.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1719548 - Part 2: Unify nsIDNService with IDNA.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, anba,
It seems you are taking holiday ? or something. The patches have been reviewed, and I have been waiting a couple of days to land this, so I've removed you as the blocking reviewer and will try to land the patches today.
I ni? you so when you come back, you could check the patches, I'll file another bug to address your comment.

Thanks

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f80d39d4529
Part 1: Add a mozilla::intl::IDNA class. r=platform-i18n-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/794339ec8d80
Part 2: Unify nsIDNService with IDNA. r=necko-reviewers,platform-i18n-reviewers,dragana,gregtatum

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3f80d39d4529
https://hg.mozilla.org/mozilla-central/rev/794339ec8d80

Comment 10

[André Bargull [:anba]]

(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh] OOO ~ April 1. from comment #7)

I ni? you so when you come back, you could check the patches, I'll file another bug to address your comment.

This patch is also looking good!