Make NativeLayerCA::ShouldSpecializeVideo check video format to only return true when detached mode is achievable
Categories
(Core :: Graphics, defect)
Tracking
()
People
(Reporter: bradwerth, Assigned: bradwerth)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
NativeLayerCA::ShouldSpecializeVideo currently checks for a pref and for the fullscreen state. However, only certain videos can take advantage of the video layer, at least until Bug 1731691 is fixed. Let's change ShouldSpecializeVideo to only return true in cases where the video will reliably hit detached mode. This may even include checking the hardware platform, as a workaround until Bug 1733499 is fixed.
|
Assignee | |
Comment 1•3 years ago
|
||
We may also be able to use this as a workaround for Bug 1732694 (webm controls disappearing) until Bug 1731136 lands.
|
|
Assignee | |
Comment 2•3 years ago
|
||
This ensures that we only do the extra work of EnqueueSurface when the video
format is eligible for the low power detached mode.
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73338c91e75f Make video layers check pixel formats to determine eligibility for layer specialization. r=mstange
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•3 years ago
|
||
Comment on attachment 9245819 [details]
Bug 1735420: Make video layers check pixel formats to determine eligibility for layer specialization.
Beta/Release Uplift Approval Request
- User impact if declined: macOS users will experience a 10% power usage increase in Netflix for fullscreen video.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This changes a heuristic of whether or not to activate a feature to cover more cases to deny activation. Both the allow and deny cases have been working as expected.
- String changes made/needed:
|
||
Comment 6•3 years ago
|
||
Comment on attachment 9245819 [details]
Bug 1735420: Make video layers check pixel formats to determine eligibility for layer specialization.
Important fix for the macOS battery life improvements being touted in Fx94. Approved for 94.0b8.
|
|
||
Comment 7•3 years ago
|
||
| bugherder uplift | ||
Description
•