1735459 - Attachments dragged from message pane trigger the "Attach Inline" overlay, regardless of the file format

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Alessandro Castellani [:aleca]]

Dragging an attachment from the attachment pane of a received email now triggers also the "Attach Inline" overlay, no matter the file format, and dropping an attachment above it doesn't do anything.

Comment 1

[Alessandro Castellani [:aleca]]

Another issue:
Dragging attachments from a received email to a new compose window doesn't attach them properly but only shows the "...part" item with 0 bytes.

Comment 2

[Alessandro Castellani [:aleca]]

While reviewing bug 1730334, I noticed that the issue reported in comment 1 seems to be fixed.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Bug 1735459 - Fix showing the attach inline overlay when dragging attachments from the message pane. r=mkmelin

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: Bug 1735459 - Fix showing the attach inline overlay when dragging attachments from the message pane. r=mkmelin

Comment 5

[Alessandro Castellani [:aleca]]

Phabricator decided to open another revision >_>

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b271e0304703
Fix showing the attach inline overlay when dragging attachments from the message pane. r=mkmelin

Comment 7

[Alessandro Castellani [:aleca]]

So, this doesn't affect 93 nor 91 since bug 1732903 wasn't uplifted.
What's the proper procedure here? Should I request an uplift for all these bugs together?
Is there a flag to specific that this patch and the patch from bug 1732903 should land together?

Comment 8

[Magnus Melin [:mkmelin]]

Yeah, just write it down in the uplift request (and in which order they need to land).

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9246247 [details]
Bug 1735459 - Fix showing the attach inline overlay when dragging attachments from the message pane. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1732903
User impact if declined: Dragging attachments from a received message to a new compose window shows "Add inline" target.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

NOTE: This patch should be uplifted right after bug 1732903 has been uplifted.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9246247 [details]
Bug 1735459 - Fix showing the attach inline overlay when dragging attachments from the message pane. r=mkmelin

[Triage Comment]
Approved for beta

patch for bug 1732903 must be uplifted first.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 94.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/7056bed97e61

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9246247 [details]
Bug 1735459 - Fix showing the attach inline overlay when dragging attachments from the message pane. r=mkmelin

[Triage Comment]
approved for esr91
Note - also need for bug 1732903

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/9c7635a0d46e