1737386 - Attachment Drag and Drop Area Limited to Outside of Highlighted Square

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[carodri2]

Attachment: Current Behavior - Notice that files are not allowed inside the box.

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36

Steps to reproduce:

1. Create a message.
2. Select a number of files to be attached to the message.
3. Drag the files to the message window.

Actual results:

Thunderbird does not attach the files until they are outside of the edges of the highlighted area, making the drag and drop operation difficult.

Expected results:

Actual drag and drop area should be large enough to allow easy drag and drop.

Comment 1

[carodri2]

Attachment: Current Behavior - Files are only accepted outside the highlighted box.

Comment 2

[WaltS48 [:walts48]]

I can reproduce using Build ID 20211023104613 on Windows 10, but can not reproduce using the same build on my Fedora 34 Workstation Linux.

On Windows 10 I can also reproduce using 94.0b4, but 91.2.1 works for me.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=0722959c51ed63b6ec1702cc2969dcd82433cf94&tochange=b271e030470355c666e601f1a5c2f34469a7bd06
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e4581e1d6e4b7bc1e647350c0fb67fd2b57e90c9&tochange=650d84a601ba81d47e31d8fcb66a6d84642ae00d

Comment 5

[Alessandro Castellani [:aleca]]

Oh wow, this is...bad!
This seems to happen only on Windows as I can't reproduce it on Linux.
Thanks for the report, and thanks Alice for the regression.

Comment 6

[carodri2]

You're welcome. I thought that fixing Bug #1457074 would take care of this and made the comment about this problem there, but yes, this is very bad.

Comment 7

[Alessandro Castellani [:aleca]]

I can confirm that this affects macOS and Windows, but not Linux.

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: Bug 1737386 - Fix attachments onDrop event not firing in macOS and Windows. r=Paenglab

Comment 9

[Alessandro Castellani [:aleca]]

Pinging Richard for a review since he can test on both macOS and Windows.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ba69c2585f8
Fix attachments onDrop event not firing in macOS and Windows. r=Paenglab

Comment 12

[Alessandro Castellani [:aleca]]

Comment on attachment 9247454 [details]
Bug 1737386 - Fix attachments onDrop event not firing in macOS and Windows. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #): bug 1735459
User impact if declined: macOS and Windows users won't be able to drag&drop attachments in the compose window.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9247454 [details]
Bug 1737386 - Fix attachments onDrop event not firing in macOS and Windows. r=Paenglab

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/ad11f7b9cc65

Comment 15

[WaltS48 [:walts48]]

Verified testing the 94.0b5 candidate on Windows 10.

Comment 17

[Alessandro Castellani [:aleca]]

Comment on attachment 9247454 [details]
Bug 1737386 - Fix attachments onDrop event not firing in macOS and Windows. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #): bug 1735459
User impact if declined: macOS and Windows users won't be able to drag&drop attachments in the compose window.
Testing completed (on c-c, etc.): on c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9247454 [details]
Bug 1737386 - Fix attachments onDrop event not firing in macOS and Windows. r=Paenglab

[Triage Comment]
Approved for esr91.

Rob We can take this for 91.3 if you are agreeable and it doesn't complicate things for you. Otherwise, feel free to pass on it.

Comment 19

[Alessandro Castellani [:aleca]]

Heads up that bug 1732903, bug 1737386, and this one, should all land together in 91 in order to not break things.

Comment 20

[Rob Lemley [:rjl]]

(In reply to Alessandro Castellani [:aleca] from comment #19)

Heads up that bug 1732903, bug 1737386, and this one, should all land together in 91 in order to not break things.

This is bug 1737386? Did you mean 1735459?

Comment 21

[Rob Lemley [:rjl]]

Thunderbird 91.3.0:
https://hg.mozilla.org/releases/comm-esr91/rev/24bf942364d9