1737696 - IsDownloadSpam() detects files downloaded through "Save link as..." context menu item as spam

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[Micah [:mtigley] (she/her)]

STR

1. Enable browser.download.enable_spam_prevention
2. Go to https://developer.mozilla.org/en-US/docs/MDN/Contribute/Getting_started
3. Open a the filepicker for "About MDN" link by choosing the "Save link as" item from the context menu. Dismiss the filepicker.
4. Repeat step 3.

Expected
The file picker should open.

Actual
The file picker doesn't open.

Notes
The issue seems goes away when the pref is disabled. This is likely caused by the IsDownloadSpam method falsely detecting the file as "spam".

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Neil Deakin]

I have come across this issue. It can be fixed by just skipping the download spam check if mForceSave is true. Can I just make a fix that does this or is there more to do here?

Comment 3

[Micah [:mtigley] (she/her)]

(In reply to Neil Deakin from comment #2)

I have come across this issue. It can be fixed by just skipping the download spam check if mForceSave is true. Can I just make a fix that does this or is there more to do here?

Nice find! And yes, feel free to fix it here (or another bug if you prefer).

Comment 4

[Neil Deakin]

Attachment: Bug 1737696, skip spam check for downloads that were saved; this allows the save link context menu item to work properly, r=mtigley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/568985165d99
skip spam check for downloads that were saved; this allows the save link context menu item to work properly, r=mtigley

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/568985165d99