Closed Bug 1737730 Opened 1 month ago Closed 1 month ago

Enable printing multiple messages at the same time

Categories

(Thunderbird :: General, defect)

Thunderbird 91
defect

Tracking

(thunderbird_esr91 fixed, thunderbird94 wontfix)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr91 --- fixed
thunderbird94 --- wontfix

People

(Reporter: darktrojan, Assigned: darktrojan)

References

()

Details

Attachments

(1 file)

I made a fix for this after all. It's not the world's greatest fix but it does work, and that is better than the current situation.

See Also: → 1727107
Duplicate of this bug: 1727865

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e66077010600
Enable printing of multiple messages. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Duplicate of this bug: 1738035

(In reply to Geoff Lankow (:darktrojan) from comment #0)

I made a fix for this after all. It's not the world's greatest fix but it does work, and that is better than the current situation.

THANK YOU. THANK YOU. THANK YOU!

Duplicate of this bug: 1738844

Tested this using the 95.0b1 release candidate on Windows 10.
It appears it calls the system dialog bypassing a preview phase, but worked.

Duplicate of this bug: 1739059

Am I understanding that the next update will have multiple email printing enabled again? Oh please say it's so! And how long will it be before the next update comes to us? My boss is having conniptions!

Yes, probably uplifted to 91 within a few weeks.

This doesn't print the list of attachments. Trying to debug this, we noticed that a debug build crashes here:
https://searchfox.org/mozilla-central/rev/df6434d2ebfdf2b5f89f205fc81d60d64a774fe1/toolkit/components/windowwatcher/nsWindowWatcher.cpp#1039

Looks like the patch here also enables printing when the preview is switched off:
https://hg.mozilla.org/comm-central/rev/e66077010600#l3.69
In that case the attachment list is also not printed.

That is really weird, but you're right. Please open a new bug.

Your QA department should take care of the necessary follow-up.

Regressions: 1741282
Duplicate of this bug: 1741321
Duplicate of this bug: 1741622
Duplicate of this bug: 1742627

Comment on attachment 9247672 [details]
Bug 1737730 - Enable printing of multiple messages. r=mkmelin

Let's get this in ESR, with or without bug 1741282. Preferably with.

[Approval Request Comment]
Regression caused by (bug #): bug 1711822
User impact if declined: can't print multiple messages or with the preview pane closed
Testing completed (on c-c, etc.): in 95 since 95 was Daily
Risk to taking this patch (and alternatives if risky): low

Attachment #9247672 - Flags: approval-comm-esr91?

Comment on attachment 9247672 [details]
Bug 1737730 - Enable printing of multiple messages. r=mkmelin

[Triage Comment]
Approved for esr91

Attachment #9247672 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.