1738206 - Add an additional action that enables the pref for TCP section in about:preferences

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

We can use a new action to enable the newly added pref "privacy.restrict3rdpartystorage.rollout.preferences.TCPToggleInStandard" that will persist showing that section in about:preferences even after the experiment end-date.
I think this works better than setting the actual TCP pref because users might be locked out of an eventual "on by default" rollout if their pref has a user-set value.
When the code rollout happens we can remove the pref and the section.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1738206 - Add an additional action that enables the pref for TCP section in about:preferences

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Bug 1738206 - Switch TCP Preferences UI to rely on Nimbus r=Mardak,pbz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f9fee41d745
Switch TCP Preferences UI to rely on Nimbus r=Mardak,pbz

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing xpcshell failures on test_FeatureManifest.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9744ed582873d0a61436a7bd08fc65afd9f930e4
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2f9fee41d745ee3a7d1d9a1ff14a03e75930ff1b&selectedTaskRun=VULbMkpNSHi8vDoZQGfstQ.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=356590151&repo=autoland // https://treeherder.mozilla.org/logviewer?job_id=356590128&repo=autoland

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c003995f9b5
Switch TCP Preferences UI to rely on Nimbus r=Mardak,pbz

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be8c4d9dd03f
Add an additional action that enables the pref for TCP section in about:preferences r=pbz

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitests failures. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/7834cedbfee522202879a4ca18a526b528d9fe96

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=5c003995f9b5c5f6687a71ec8fc3aec84efbac37&selectedTaskRun=E-zaVTsqQQizzvSitV3_QA.0

Link to failure log :
https://treeherder.mozilla.org/logviewer?job_id=356613978&repo=autoland&lineNumber=11170
https://treeherder.mozilla.org/logviewer?job_id=356615029&repo=autoland&lineNumber=3649
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=5c003995f9b5c5f6687a71ec8fc3aec84efbac37&selectedTaskRun=dCUt-LbVQP-a0dFZfzESNQ.0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92c62ad10b81
Switch TCP Preferences UI to rely on Nimbus r=Mardak,pbz

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11b636779958
Add an additional action that enables the pref for TCP section in about:preferences r=pbz

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/92c62ad10b81
https://hg.mozilla.org/mozilla-central/rev/11b636779958

Comment 11

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: This implements the desired nimbus rollout logic for about:preferences checkbox added in bug 1737565.

Comment 12

[Andrei Oprea [:andreio]]

STR for testing.

1. Install the Remote Settings devtools addon and point to the Stage (Preview) collection
2. Enable the nimbus.debug preference
3. Test the two different branches of the experiment:

• about:studies?optin_slug=test-tcp-rollout-experimenter&optin_branch=control
• about:studies?optin_slug=test-tcp-rollout-experimenter&optin_branch=treatment

For the control branch there should be no message shown but when going to about:preferences the checkbox for the new feature should appear (Privacy & Security > Test pilot our most powerful privacy feature ever). We're testing that we can remotely enable the feature for people

For the treatment branch the message (spotlight modal) should appear on restart. If any action such as ignoring, dismissing etc (any action that isn't the OK button) is taken the feature should still be visible in about:preferences. Clicking OK enables the feature. Clicking Not Now and then unenrolling from the experiment should still keep the option in about:preferences.

If no action at all is taken (window is closed without interacting with the message) and then we unenroll from the experiment the feature will not be visible in about:preferences.

Comment 13

[Paul Zühlcke [:pbz]]

Comment on attachment 9248194 [details]
Bug 1738206 - Add an additional action that enables the pref for TCP section in about:preferences

Beta/Release Uplift Approval Request

• User impact if declined: These patches are a requirement for the Total Cookie Protection rollout experiment starting in Firefox 95. See meta Bug 1731713 / https://mozilla-hub.atlassian.net/browse/UJET-121
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1738206#c12
• List of other uplifts needed: Bug 1739619
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patches have good automated test coverage and the production code changes are relatively small.
• String changes made/needed: -

Comment 14

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following using the steps provided in comment 12 on Firefox Nightly 96.0a1 (Build ID: 20211111045525) with Windows 10 x64:

1. Successfully enrolled in both the Control and the Treatment branches.
2. For the Treatment branch:

• The spotlight is successfully displayed after a restart is performed
• The "Test pilot our most powerful privacy feature ever" checkmark is displayed in the "about:preferences#privacy" page with the following caveats:
  • If the spotlight was dismissed or the "Not Now" button was clicked, the checkmark is unchecked.
  • If the spotlights primary button, "Turn on Total Cookie Protection", was clicked, the checkmark is checked.

3. For the Control branch:

• The "Test pilot our most powerful privacy feature ever" checkmark is displayed in the "about:preferences#privacy" page.

Comment 15

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9248194 [details]
Bug 1738206 - Add an additional action that enables the pref for TCP section in about:preferences

Approved for 95.0b6

Comment 16

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

https://hg.mozilla.org/releases/mozilla-beta/rev/21c5c824672a
https://hg.mozilla.org/releases/mozilla-beta/rev/cb6c1dbadaec

Comment 17

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following using the steps provided in comment 12 on Firefox Beta 95.0b6 (Build ID: 20211111195813) with Windows 10 x64:

1. Successfully enrolled in both the Control and the Treatment branches.
2. For the Treatment branch:
   -The spotlight is successfully displayed after a restart is performed
   -The "Test pilot our most powerful privacy feature ever" checkmark is displayed in the "about:preferences#privacy" page with the following caveats:
   -If the spotlight was dismissed or the "Not Now" button was clicked, the checkmark is unchecked.
   -If the spotlights primary button, "Turn on Total Cookie Protection", was clicked, the checkmark is checked.
3. For the Control branch:

• The "Test pilot our most powerful privacy feature ever" checkmark is displayed in the "about:preferences#privacy" page.