1738458 - Think about checking all installed add-ons for updates on app upgrade

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, task)

Description

[John Bieling (:TbSync)]

Here we probably only check for appDisabled add-ons, but not for normal add-ons, which could have a newer/better version available (and the current one incorrectly not marked as incompatible)

https://searchfox.org/comm-central/source/mail/components/MailGlue.jsm#452-454

Comment 2

[John Bieling (:TbSync)]

While creating a test case for this bug, I saw that even the expected case (update rendered an add-on incompatible) is not causing the add-on to update.

STR:

• fresh TB78 profile
• install https://addons.thunderbird.net/thunderbird/downloads/file/1018660/quicktext-3.6-tb.xpi
• update the profile to TB91
• add-on is correctly marked as incompatible, but not updated, user has to manually search for updates (this is what the startupChanges check should take care off).

What this bug is actually about is to update add-ons if there is a new version available for the new platform, even if the current installed version is not defined incompatible. Consider
v1.0: https://github.com/jobisoft/github-based-release-example/blob/versions/bug1738458/1.0/manifest.json
v1.1: https://github.com/jobisoft/github-based-release-example/blob/versions/bug1738458/1.1/manifest.json

v1.1 might use new API feature introduced in TB91 or v1.0 may in fact be incompatible with TB91, as some API could have been deprecated. When updating to TB91, version v1.1 should be automatically installed.

Removing the check for startupChanges (which does not seem to work anymore) fixes both.

Comment 3

[John Bieling (:TbSync)]

Attachment: Bug 1738458 - Update add-ons if new version of Thunderbird has been installed. r=mkmelin

Comment 4

[John Bieling (:TbSync)]

Add-ons not being updated on app upgrade always caused a big uptick in support requests and even breaking TB due to incompatibilities.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6b660426434a
Update add-ons if new version of Thunderbird has been installed. r=mkmelin

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9249214 [details]
Bug 1738458 - Update add-ons if new version of Thunderbird has been installed. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Add-on might not update on app upgrade

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Very low.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9249214 [details]
Bug 1738458 - Update add-ons if new version of Thunderbird has been installed. r=mkmelin

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 95.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5f10dddb94df

Comment 9

[John Bieling (:TbSync)]

Comment on attachment 9249214 [details]
Bug 1738458 - Update add-ons if new version of Thunderbird has been installed. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Add-on might not update on app upgrade

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Very low.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9249214 [details]
Bug 1738458 - Update add-ons if new version of Thunderbird has been installed. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 91.3.1:
https://hg.mozilla.org/releases/comm-esr91/rev/b5ef3619f12b